Skip to content

Conversation

@shiv19
Copy link

@shiv19 shiv19 commented May 27, 2024

I've migrated the start branch of the code to use Capacitor 6.
After the migration I was able to follow all the steps mentioned in the tutorial.

Minus this part, where on iOS the ScreenOrientationPlugin does not automatically get added to the packageClassList in the generated capacitor.config.json file of the iOS project. When I add this in manually, it does make the plugin work correctly.
ionic-team/capacitor#7405 (reply in thread)

@shiv19
Copy link
Author

shiv19 commented May 27, 2024

The lock implementation is different for iOS 16+
So the plugin tutorial needs to be updated for Capacitor 6 docs, if we wish to update the starter branch of this repo.

https://github.com/ionic-team/capacitor-plugins/blob/acd334dae7fc7545446cafc8fbb469200f7831f8/screen-orientation/ios/Sources/ScreenOrientationPlugin/ScreenOrientation.swift#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant