Conversation
| Please refer to PR #1419. @N-R-K @luukvbaal please take a call. |
src/icons.h Outdated
| {"lua", ICON_EXT_LUA, COLOR_LUA}, | ||
| {"lzh", ICON_ARCHIVE, COLOR_ARCHIVE}, | ||
| {"lzma", ICON_ARCHIVE, COLOR_ARCHIVE}, | ||
| {"lock", ICON_LOCKFILE, 0}, |
There was a problem hiding this comment.
What's the "lock" extension used for and how common is it? Quick internet search seems to suggest it's something related to minecraft?
There was a problem hiding this comment.
No some package managers/build systems maintain a 'lock' file to freeze the dependencies to specific version so that when the app is built builder knows exact versions to pick. Elixir's mix is one such tool. In elixir, mix.exs stores the dependencies and mix.lock has exact versions and other details.
N-R-K left a comment
N-R-K left a comment There was a problem hiding this comment.
Elixir seems to be somewhat popular. Think we can take that.
I'm fine skipping Erlang and "lock".
| @N-R-K please confirm when we are good to merge. |
| @jarun Pushed the changes. Should be good to merge. (Probably should "squash-merge" it though). |
| Thank you! |
3 participants
Hi, I added Erlang and Elixir icons with colors for different related file extensions. Let me know if I have done anything wrong or unacceptable.