fix(dependencies): aws sdk v3 packages are dependencies not devDependencies #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Hey @oieduardorabelo, first of all, thank you for this! could you move them to be peer dependencies instead? |
Contributor Author
| back to you @naorpeled |
naorpeled approved these changes Mar 12, 2023
Contributor Author
| the ci is failing because the version of npm in node 14 is less than 7: https://github.com/jeremydaly/lambda-api/actions/runs/4399624238/jobs/7704331228 npm 7+ install peer dependencies by default, npm 6 and below don't |
Collaborator
Let's set a custom npm version in CI then, wdyt? |
Contributor Author
This was referenced Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
prettierin code to fix failing ci https://github.com/jeremydaly/lambda-api/actions/runs/4388737872/jobs/7685568423cc @naorpeled