Skip to content

fix(s3-service/getObject): resolve wrong output type received #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 3, 2023
Merged

fix(s3-service/getObject): resolve wrong output type received #236

merged 24 commits into from
Jun 3, 2023

Conversation

@naorpeled
Copy link
Collaborator

@naorpeled naorpeled commented Jun 2, 2023 •
edited
Loading

  • before this change, we received [object Object] because the AWS SDK returned us a stream instead of a buffer like it used to be in v2, and it was dealt with like a buffer

resolves #234
@naorpeled naorpeled mentioned this pull request Jun 2, 2023
Closed
@naorpeled naorpeled changed the title fix(s3-service): make great again fix(s3-service/getObject): make great again Jun 3, 2023
@naorpeled naorpeled changed the title fix(s3-service/getObject): make great again fix(s3-service/getObject): resolve wrong output type received Jun 3, 2023
@naorpeled naorpeled merged commit 4322589 into main Jun 3, 2023
@naorpeled naorpeled deleted the make-s3-middleware-great-again branch June 3, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@naorpeled