LFX: Add the file watcher and its test back to KCL #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| This may not work, because CI's tests will depend on the release version of kpm |
Contributor Author
| @He1pa can you please rerun the CI so we can move forward with this PR? |
Signed-off-by: Siddhi Agrawal <siddhi3agrawal@gmail.com>
Siddhi-agg force-pushed the lsp-kpm-integration branch from 21841f3 to 8c0f729 Compare Contributor Author
| @He1pa One of the tests is working, I will look into the other one but can we merge this PR first? |
Signed-off-by: Siddhi Agrawal <siddhi3agrawal@gmail.com>
Siddhi-agg force-pushed the lsp-kpm-integration branch from ad93536 to 6266311 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re [LFX] KPM & LSP Integrated #1847
2. What is the scope of this PR (e.g. component or file name):
kcl/kclvm/tools/src/LSP/src/tests.rs
kcl/kclvm/tools/src/LSP/src/state.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: