Fix flaky test

[thekid]

This pull request fixes streams_001.phpt if the default compression level compresses better than level 6, which is specified in the test.

Summary by CodeRabbit

• Tests
  • Corrected a minor text error in output messages.
  • Refined validation checks to ensure accurate data integrity during compression tests.

[coderabbitai]

Walkthrough

The changes update the Brotli compression test in tests/streams_001.phpt. The typo in the output string is corrected from "defaul" to "default" and the assertion logic now compares the compressed data size against strlen($data) rather than using an earlier size variable. The test now more accurately validates the compression result without altering the overall functionality.

Changes

File(s)	Summary of Changes
tests/streams_001.phpt	Corrected output string typo ("defaul" → "default") and updated assertion logic to compare compressed size with strlen($data) instead of a previous size.

Sequence Diagram(s)

sequenceDiagram participant TestRunner as Test Runner participant Brotli as Brotli Compression TestRunner->>Brotli: Compress input data Brotli-->>TestRunner: Return compressed data TestRunner->>TestRunner: Compute strlen(data) TestRunner->>TestRunner: Compare compressed size with strlen(data) TestRunner-->>TestRunner: Echo "default" with corrected message 

Loading

Poem

I'm a rabbit, hopping in delight,
Fixing typos and logic with all my might.
"default" now sings in the test stream so bright,
Assertions now check with precision and light.
Hoppy leaps for code that feels just right! 🐇

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/streams_001.phpt (1)

9-9: Fixed typo in output message.

The typo "defaul" has been corrected to "default" in the output message, improving clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a7dba1b and 6ec91cb.

📒 Files selected for processing (1)

• tests/streams_001.phpt (3 hunks)

🔇 Additional comments (2)

tests/streams_001.phpt (2)

27-27: Improved test reliability by fixing the size comparison logic.

The previous assertion compared $size2 against $size1, which could cause test failures when the default compression level achieves better compression than level 6. The updated logic now correctly validates that the compressed data is smaller than the original data, preventing the test from being flaky.

This change directly addresses the PR objective of fixing the flaky test issue described in the PR summary.

---

38-38: Fixed typo in expected output to match the actual output message.

The typo in the expected output has been corrected to ensure it matches the fixed output message from line 9, preventing test failures due to output mismatch.

[kjdev]

Thanks.