Fix bugs in ChoiceType's name

[ukeloop]

Fix bugs in ChoiceType's name.

Related issues

• Bugs when modding multiple times with multiple #677
• Multiple checkboxes in plain subform get double [][] #324
• Checkbox get two "[][]" if using modify #305

[rudiedirkx]

Yeeaah, but tmp is so ugly... =( I rather just get rid of ChoiceType and ParentType and create a breaking 2.x with a very simple upgrade path. It's always problems with these fields 😠

I'm okay with this PR, because I don't use ChoiceType, so I know it definitely won't break my code, but I'm not sure enough about ChoiceType ever.

[rudiedirkx]

LOL what a complainer #324 :D

[Eloar]

@ukeloop why tmp, why not internal if those options are not supposed to be exposed in view?

[ukeloop]

@Eloar

See that:

laravel-form-builder/src/Kris/LaravelFormBuilder/Fields/FormField.php

Lines 304 to 307 in d8c2ba6

	if ($this->getOption('attr.multiple') && !$this->getOption('tmp.multipleBracesSet')) {
	$this->name = $this->name . '[]';
	$this->setOption('tmp.multipleBracesSet', true);
	}