Conversation
Allow zip_stream_open to accept 'd' mode so callers can delete entries from an in-memory archive without duplicating the buffer. A dedicated write function (zip_stream_delete_write_func) keeps the same heap-write semantics as miniz but uses a distinct pointer so mz_zip_writer_end won't free the caller's buffer—no miniz changes required. Seven new ASan-clean tests cover delete-by-name, delete-by-index, invalid indices, close-without-copy, open-then-close, delete-all, and multiple zip_stream_copy calls.
There was a problem hiding this comment.
Pull request overview
Adds support for opening in-memory ZIP archives in delete mode ('d') so callers can remove entries from a memory-backed archive and then obtain the modified archive via zip_stream_copy(), without requiring miniz changes.
Changes:
- Add a dedicated in-memory write callback for delete mode to avoid miniz freeing the caller’s buffer on close.
- Extend
zip_stream_openwitherror()to accept'd'mode for memory streams. - Add a suite of stream-delete tests (delete by name/index, invalid indices, open/close cases, delete-all, multi-copy).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/test_entry.c | Adds new test coverage for stream-based delete mode workflows. |
src/zip.h | Documents new 'd' mode for zip_stream_open*() APIs. |
src/zip.c | Implements 'd' mode for stream open and a custom write function to preserve caller buffer ownership. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…ks (#392) * Initial plan * Remove unsupported 'a' mode from zip_stream_open*() doc blocks Co-authored-by: kuba-- <4056521+kuba--@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kuba-- <4056521+kuba--@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow zip_stream_open to accept 'd' mode so callers can delete entries from an in-memory archive without duplicating the buffer. A dedicated write function (zip_stream_delete_write_func) keeps the same heap-write semantics as miniz but uses a distinct pointer so mz_zip_writer_end won't free the caller's buffer—no miniz changes required.
Seven new ASan-clean tests cover delete-by-name, delete-by-index, invalid indices, close-without-copy, open-then-close, delete-all, and multiple zip_stream_copy calls.