Add secret reference in PV annotations for ControllerModifyVolume #1440
+51 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added release-note k8s-ci-robot added cncf-cla: yes 
Contributor
| /lgtm /assign @gnufied @xing-yang |
k8s-ci-robot added the lgtm 
The ControllerModifyVolume CSI procedure should be able to receive credentials if the storage provider requires them. The values of the following keys in the StorageClass are copied into annotations of the PersistentVolume: - csi.storage.k8s.io/controller-modify-secret-name > volume.kubernetes.io/controller-modify-secret-name - csi.storage.k8s.io/controller-modify-secret-namespace > volume.kubernetes.io/controller-modify-secret-namespace The external-resizer can use these annotations to resolve the secret that needs to be passed in ControllerModifyVolume.
nixpanic force-pushed the credentials/modify branch from fedaeb6 to a81a21c Compare k8s-ci-robot removed the lgtm 
Contributor
| New changes are detected. LGTM label has been removed. |
Contributor
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nixpanic The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files: Approvers can indicate their approval by writing |
This was referenced Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The ControllerModifyVolume CSI procedure should be able to receive credentials if the storage provider requires them.
The values of the following keys in the StorageClass are copied into annotations of the PersistentVolume:
The external-resizer can use these annotations to resolve the secret that needs to be passed in ControllerModifyVolume.
Which issue(s) this PR fixes:
Related to kubernetes-csi/external-resizer#544
Special notes for your reviewer:
Approach has been discussed in a thread at #csi.
Does this PR introduce a user-facing change?: