Skip to content

Apply Features flags (related to pprof) #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

Apply Features flags (related to pprof) #130

merged 1 commit into from
Dec 9, 2022

Conversation

@olivierlemasle
Copy link
Contributor

@olivierlemasle olivierlemasle commented Dec 8, 2022

The flags "profiling" and "contention-profiling", provided by FeatureOptions, are already added by custom-metrics-apiserver, but were not applied.
@olivierlemasle
Apply Features flags (related to pprof)
a7c2ab6 
The flags "profiling" and "contention-profiling", provided by FeatureOptions, are already added by custom-metrics-apiserver, but were not applied.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 8, 2022

@olivierlemasle: This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@dgrisonnet
Copy link
Member

dgrisonnet commented Dec 9, 2022

Thank you for splitting the original PR!

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit e61b02b into kubernetes-sigs:master Dec 9, 2022
@olivierlemasle olivierlemasle deleted the apply-features branch December 9, 2022 15:17
@dgrisonnet dgrisonnet mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

3 participants

@olivierlemasle @k8s-ci-robot @dgrisonnet