allow for node/$nodename resource form#36
Merged
kvaps merged 3 commits intokvaps:masterfrom Jan 6, 2022
madeddie:patch-1
Merged
allow for node/$nodename resource form#36kvaps merged 3 commits intokvaps:masterfrom madeddie:patch-1
kvaps merged 3 commits intokvaps:masterfrom
madeddie:patch-1
Conversation
I sometimes use this plugin with a `for node in $(kubectl get names -o node); do kubectl node-shell "$node" -- something` loop. The kubectl get names -o node outputs a list of nodenames prefixed with the `node/` type. This change will, always, simply filter out `node/` at the beginning of the node name.
kvaps requested changes Dec 30, 2021
Owner
kvaps left a comment
kvaps left a comment There was a problem hiding this comment.
That definitely makes sense.
Please also update the plugin version on line 5
kvaps reviewed Jan 1, 2022
Co-authored-by: Andrei Kvapil <kvapss@gmail.com>
kvaps approved these changes Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sometimes use this plugin with a
for node in $(kubectl get names -o node); do kubectl node-shell "$node" -- somethingloop. The kubectl get names -o node outputs a list of nodenames prefixed with thenode/type.This change will, always, simply filter out
node/at the beginning of the node name.