Skip to content

default value for TENCENT_COS_CUSTOM_DOMAIN is not necessary #31848

@Tabll

Description

@Tabll

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.11.4

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

just update version to 1.11.4

the error is:

 File "/app/api/.venv/lib/python3.12/site-packages/qcloud_cos/cos_client.py", line 569, in get_object rt = self.send_request( ^^^^^^^^^^^^^^^^^^ File "/app/api/.venv/lib/python3.12/site-packages/qcloud_cos/cos_client.py", line 451, in send_request raise CosClientError(str(e)) qcloud_cos.cos_exception.CosClientError: HTTPSConnectionPool(host='your-custom-domain', port=443): Max retries exceeded with url: /privkeys/a901cc01-7c0f-4088-9df1-d1a7b128920f/private.pem (Caused by NameResolutionError("HTTPSConnection(host='your-custom-domain', port=443): Failed to resolve 'your-custom-domain' ([Errno -3] Temporary failure in name resolution)"))

✔️ Expected Behavior

I only used Tencent Cloud COS but didn't use a custom domain, so I didn't configure TENCENT_COS_CUSTOM_DOMAIN. This usage should be supported, but in the docker-compose.yaml file, it was given a default value.

https://github.com/langgenius/dify/blob/main/docker/docker-compose.yaml#L152
TENCENT_COS_CUSTOM_DOMAIN: ${TENCENT_COS_CUSTOM_DOMAIN:-your-custom-domain}

❌ Actual Behavior

The domain name was forcibly set to "your-custom-domain", and setting it to empty or None had no effect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions