Skip to content

refactor(models): Add mapped type hints to MessageAnnotation#27751

Merged
crazywoola merged 3 commits intomainfrom
feat/add-type-annotations-to-message-annotation-model
Jan 5, 2026
Merged

refactor(models): Add mapped type hints to MessageAnnotation#27751
crazywoola merged 3 commits intomainfrom
feat/add-type-annotations-to-message-annotation-model

Conversation

@laipz8200
Copy link
Member

Summary

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the 'MessageAnnotation' SQLAlchemy model by introducing 'Mapped' type hints for various fields and explicitly annotating timestamp columns with 'datetime'. These changes improve type consistency and clarity, aligning the model with modern SQLAlchemy typing practices and resolving a reported issue.

Highlights

  • Type Hinting Consistency: Introduced 'Mapped' type hints for several fields within the 'MessageAnnotation' model to align with typed SQLAlchemy conventions.
  • Timestamp Clarity: Explicitly annotated 'created_at' and 'updated_at' columns with 'datetime' type hints for improved clarity.
  • Issue Resolution: This pull request addresses and fixes issue [Chore/Refactor] Add SQLAlchemy mapped type hints to MessageAnnotation #27750.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Mapped type hints to several fields in the MessageAnnotation model in api/models/model.py. Specifically, question, content, account_id, created_at, and updated_at are now explicitly typed. This is a good improvement that aligns with modern SQLAlchemy practices, enhancing code clarity and enabling better static type checking. The changes are correct and well-implemented. No issues found.

@laipz8200
Copy link
Member Author

laipz8200 commented Nov 3, 2025

It seems message_annotations.question has never been None; otherwise, it would mean we’ve had a bug here for a long time.

cc @snakevash

@laipz8200 laipz8200 changed the title Add mapped type hints to MessageAnnotation refactor(models): Add mapped type hints to MessageAnnotation Nov 3, 2025
@laipz8200 laipz8200 modified the milestone: 1.10.1 Nov 18, 2025
crazywoola
crazywoola previously approved these changes Nov 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2025
@crazywoola crazywoola self-requested a review November 27, 2025 02:46
@crazywoola crazywoola removed the lgtm This PR has been approved by a maintainer label Nov 27, 2025
@asukaminato0721 asukaminato0721 self-requested a review November 27, 2025 03:29
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2025
@laipz8200 laipz8200 marked this pull request as draft January 4, 2026 14:29
@laipz8200 laipz8200 force-pushed the feat/add-type-annotations-to-message-annotation-model branch from b25584f to 0e5bda4 Compare January 4, 2026 14:35
@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 14:55
@crazywoola crazywoola merged commit a99ac3f into main Jan 5, 2026
15 checks passed
@crazywoola crazywoola deleted the feat/add-type-annotations-to-message-annotation-model branch January 5, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

3 participants