Skip to content

feat: optimize for migration versions#28787

Merged
asukaminato0721 merged 11 commits intolanggenius:mainfrom
longbingljw:optimize
Jan 3, 2026
Merged

feat: optimize for migration versions#28787
asukaminato0721 merged 11 commits intolanggenius:mainfrom
longbingljw:optimize

Conversation

@longbingljw
Copy link

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

I want to simplify the modification of migration version files when adapting to MySQL.In the past, when I adapted the code for MySQL, I used conditional statements to ensure the PostgreSQL parts remained unaffected. However, we can actually reduce some of these conditionals to optimize the code.

close #28455
close #26422

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 27, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @longbingljw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring database migration scripts to eliminate conditional logic based on the database dialect (PostgreSQL vs. MySQL). By standardizing column type definitions and removing database-specific checks, the changes aim to make the migration files cleaner, more concise, and easier to manage, particularly when adapting to different database systems like MySQL.

Highlights

  • Migration Version Optimization: Simplified database migration scripts by removing redundant conditional logic that previously differentiated between PostgreSQL and MySQL. This streamlines the code and improves maintainability.
  • Standardized Column Types: Replaced database-specific column type definitions (e.g., sa.Text() for PostgreSQL, models.types.LongText() for MySQL) with a unified, database-agnostic approach using models.types.LongText() or models.types.StringUUID() where appropriate.
  • Code Cleanup: Removed the _is_pg helper function and associated conn = op.get_bind() calls from numerous migration files, further cleaning up the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great refactoring effort to simplify the database migration files. By removing dialect-specific conditional logic (for PostgreSQL vs. MySQL) and using custom SQLAlchemy types (models.types.LongText, models.types.StringUUID, etc.), the migration scripts have become much cleaner, more readable, and easier to maintain. The changes are consistent across all modified files and correctly apply the intended abstraction. This significantly improves the codebase's portability and reduces redundancy. I've reviewed the changes and they look solid. Well done!

@crazywoola crazywoola requested a review from laipz8200 November 27, 2025 12:47
longbing added 3 commits December 15, 2025 11:47
This reverts commit 0d022f6.
This reverts commit b142c57.
This reverts commit a4aa35f.
@longbingljw
Copy link
Author

I will create a new pr to add seekdb logic in vector store and adapt for mysql

@longbingljw longbingljw changed the title feat:optimize for migration versions feat: optimize for migration versions Dec 15, 2025
@laipz8200 laipz8200 requested a review from MRZHUH as a code owner December 19, 2025 18:30
@longbingljw longbingljw deleted the optimize branch February 6, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

3 participants