Skip to content

fix: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build#29836

Merged
crazywoola merged 2 commits intolanggenius:mainfrom
darkelf21cn:kimiwang/web-base-url-251218
Jan 5, 2026
Merged

fix: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build#29836
crazywoola merged 2 commits intolanggenius:mainfrom
darkelf21cn:kimiwang/web-base-url-251218

Conversation

@darkelf21cn
Copy link
Contributor

@darkelf21cn darkelf21cn commented Dec 18, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #25352

To allow dify-web to use a different base path, users need to set the NEXT_PUBLIC_BASE_PATH environment variable at build time. However, in the current Dockerfile, NEXT_PUBLIC_BASE_PATH is an environment variable and cannot be configured at build time by default according to the Docker documentation. Convert it to a build argument so users can change it by specifying --build-arg NEXT_PUBLIC_BASE_PATH=/CHANGEME when building the image.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@darkelf21cn darkelf21cn requested a review from iamjoel as a code owner December 18, 2025 03:59
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @darkelf21cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the dify-web Docker build by enabling the NEXT_PUBLIC_BASE_PATH environment variable to be configured at build time. By transitioning it to a build argument, users can now easily customize the application's base path when constructing the Docker image, which is crucial for various deployment environments.

Highlights

  • Dockerfile Configuration: The web/Dockerfile has been updated to convert NEXT_PUBLIC_BASE_PATH from a direct ENV variable to a BUILD_ARG. This change allows users to specify the base path during the Docker image build process using the --build-arg flag.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly enables configuration of NEXT_PUBLIC_BASE_PATH at Docker build time by converting it from a static ENV to a build ARG. This is a common and correct pattern for making Docker images more flexible. The change is well-contained and addresses the described issue effectively. The implementation is solid and I have no suggestions for improvement.

@darkelf21cn darkelf21cn changed the title Fixes #25352 support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build Fixes #25352: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build Dec 18, 2025
@crazywoola
Copy link
Member

Please link an existing issue or create a new issue.

@darkelf21cn
Copy link
Contributor Author

Please link an existing issue or create a new issue.

Done—but the issue was already closed. Does that matter?

@darkelf21cn darkelf21cn changed the title Fixes #25352: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build fix: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build Dec 24, 2025
@darkelf21cn
Copy link
Contributor Author

@crazywoola Hi, I have linked this PR to an existed issue. Did you get a chance to review it again? Thanks.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola crazywoola merged commit c158dfa into langgenius:main Jan 5, 2026
15 of 18 checks passed
@dosubot dosubot bot mentioned this pull request Jan 24, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants