fix: support to change NEXT_PUBLIC_BASE_PATH env using --build-arg in docker build#29836
Conversation
Summary of ChangesHello @darkelf21cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly enables configuration of NEXT_PUBLIC_BASE_PATH at Docker build time by converting it from a static ENV to a build ARG. This is a common and correct pattern for making Docker images more flexible. The change is well-contained and addresses the described issue effectively. The implementation is solid and I have no suggestions for improvement.
--build-arg in docker build--build-arg in docker build | Please link an existing issue or create a new issue. |
Done—but the issue was already closed. Does that matter? |
--build-arg in docker build--build-arg in docker build | @crazywoola Hi, I have linked this PR to an existed issue. Did you get a chance to review it again? Thanks. |
Important
Fixes #<issue number>.Summary
Fixes #25352
To allow dify-web to use a different base path, users need to set the NEXT_PUBLIC_BASE_PATH environment variable at build time. However, in the current Dockerfile, NEXT_PUBLIC_BASE_PATH is an environment variable and cannot be configured at build time by default according to the Docker documentation. Convert it to a build argument so users can change it by specifying --build-arg NEXT_PUBLIC_BASE_PATH=/CHANGEME when building the image.
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods