refactor(i18n): use JSON with flattened key and namespace#30114
refactor(i18n): use JSON with flattened key and namespace#30114hyoban merged 57 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring of the application's internationalization system. The primary goal is to streamline translation management by migrating from TypeScript-based translation files to a more standard and easily parsable JSON format. This change simplifies the underlying logic for processing and validating translation content, making the system more robust and maintainable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed refactoring to migrate translation files from TypeScript (.ts) to JSON (.json). This change simplifies the tooling and build process for internationalization by removing dependencies like vm, transpile, and magicast. The updates are consistently applied across test files, helper scripts, and application components. The new implementation for handling translations is much cleaner and more robust.
I've identified a potential issue in the updated scripts (auto-gen-i18n.js and check-i18n.js) where parsing an empty translation file would cause a crash. I've provided specific comments and code suggestions to handle this edge case gracefully. Overall, this is an excellent improvement to the codebase.
50b91bf to 1c8d7ae Compare There was a problem hiding this comment.
Pull request overview
This PR refactors German (de-DE) translation files from TypeScript to JSON format as part of issue #30111. The migration maintains all translation content while converting from .ts files with exported translation objects to .json files with pure JSON structure.
Key Changes
- Converted 13 German translation files from TypeScript to JSON format
- Removed corresponding
.tsfiles after migration - Removed empty Arabic translation file (ar-TN/register.ts)
Reviewed changes
Copilot reviewed 95 out of 1324 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/i18n/de-DE/*.json | New JSON translation files for dataset, settings, documents, creation, testing, and app-related translations |
| web/i18n/de-DE/*.ts | Removed TypeScript translation files after migration to JSON |
| web/i18n/ar-TN/register.ts | Removed empty Arabic translation file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
| If anyone has a merge conflict with this PR, ping me |
Important
Fixes #<issue number>.Summary
part of #30111
Fixes #30135
Fixes #30136
Fixes #30137
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods