Skip to content

refactor(i18n): use JSON with flattened key and namespace#30114

Merged
hyoban merged 57 commits intolanggenius:mainfrom
hyoban:12-24-json-for-translation
Dec 29, 2025
Merged

refactor(i18n): use JSON with flattened key and namespace#30114
hyoban merged 57 commits intolanggenius:mainfrom
hyoban:12-24-json-for-translation

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Dec 24, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #30111
Fixes #30135
Fixes #30136
Fixes #30137

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring of the application's internationalization system. The primary goal is to streamline translation management by migrating from TypeScript-based translation files to a more standard and easily parsable JSON format. This change simplifies the underlying logic for processing and validating translation content, making the system more robust and maintainable.

Highlights

  • Translation File Format Migration: The internationalization (i18n) system has been refactored to use JSON files (.json) for translations instead of TypeScript files (.ts). This simplifies how translation content is handled and parsed.
  • Simplified Translation Handling Logic: The scripts responsible for auto-generating and checking i18n files (auto-gen-i18n.js, check-i18n.js) have been updated to directly parse and stringify JSON, removing complex dependencies on vm, magicast, and typescript for .ts file processing.
  • Updated Test and Component Imports: Existing tests (i18n-upload-features.test.ts) and UI components (category.tsx) have been adjusted to correctly import and interact with the new JSON-based translation files, including updating validation logic from regex to direct object property access.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant and well-executed refactoring to migrate translation files from TypeScript (.ts) to JSON (.json). This change simplifies the tooling and build process for internationalization by removing dependencies like vm, transpile, and magicast. The updates are consistently applied across test files, helper scripts, and application components. The new implementation for handling translations is much cleaner and more robust.

I've identified a potential issue in the updated scripts (auto-gen-i18n.js and check-i18n.js) where parsing an empty translation file would cause a crash. I've provided specific comments and code suggestions to handle this edge case gracefully. Overall, this is an excellent improvement to the codebase.

@hyoban hyoban force-pushed the 12-24-json-for-translation branch from 50b91bf to 1c8d7ae Compare December 25, 2025 02:27
@hyoban hyoban marked this pull request as ready for review December 25, 2025 02:31
@hyoban hyoban requested a review from CodingOnStar as a code owner December 25, 2025 02:31
Copilot AI review requested due to automatic review settings December 25, 2025 02:31
@hyoban hyoban requested a review from iamjoel as a code owner December 25, 2025 02:31
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors German (de-DE) translation files from TypeScript to JSON format as part of issue #30111. The migration maintains all translation content while converting from .ts files with exported translation objects to .json files with pure JSON structure.

Key Changes

  • Converted 13 German translation files from TypeScript to JSON format
  • Removed corresponding .ts files after migration
  • Removed empty Arabic translation file (ar-TN/register.ts)

Reviewed changes

Copilot reviewed 95 out of 1324 changed files in this pull request and generated no comments.

File Description
web/i18n/de-DE/*.json New JSON translation files for dataset, settings, documents, creation, testing, and app-related translations
web/i18n/de-DE/*.ts Removed TypeScript translation files after migration to JSON
web/i18n/ar-TN/register.ts Removed empty Arabic translation file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hyoban hyoban marked this pull request as draft December 25, 2025 02:39
@hyoban hyoban changed the title refactor: use json for translation refactor: use JSON with flattened key for translation Dec 25, 2025
@hyoban hyoban marked this pull request as ready for review December 25, 2025 09:16
@hyoban hyoban requested review from douxc and zxhlyh as code owners December 25, 2025 09:16
@hyoban hyoban closed this Dec 29, 2025
@hyoban hyoban reopened this Dec 29, 2025
@hyoban
Copy link
Member Author

hyoban commented Dec 29, 2025

npx tsx scripts/analyze-i18n-diff.ts

🔍 Analyzing i18n differences between current branch (flat JSON) and main branch (nested TS)... 📂 Checking namespace files... ============================================================ Namespaces in main branch (ts files): 30 JSON files in current branch: 30 TS files in current branch: 0 ✅ All namespaces from main branch have corresponding JSON files ✅ No TS files in current branch (all converted to JSON) 📊 Key Analysis Summary ============================================================ Total files analyzed: 30 Missing keys (in main but not in current): 0 Changed values: 0 New keys: 22 ✨ NEW KEYS (exist in current branch but not in main) ============================================================ 📁 billing: + plans.community.priceTip: "" 📁 dataset-documents: + metadata.languageMap.ro: "Romanian" 📁 dataset: + indexingMethod.keyword_search: "KEYWORD" + retrieval.invertedIndex.description: "Inverted Index is a structure used for efficient retrieval. Organized by terms, each term points to documents or web pages containing it." + retrieval.invertedIndex.title: "Inverted Index" 📁 explore: + category.Recommended: "Recommended" 📁 tools: + addToolModal.agent.tip: "" + addToolModal.all.tip: "" + addToolModal.all.title: "No tools available" + addToolModal.built-in.tip: "" + addToolModal.built-in.title: "No built-in tool available" + createTool.authMethod.types.api_key: "API Key" 📁 workflow: + blocks.datasource-empty: "Empty Data Source" + blocks.tool: "Tool" + blocksAbout.datasource-empty: "Empty Data Source placeholder" + blocksAbout.iteration-start: "Iteration Start node" + blocksAbout.loop-start: "Loop Start node" + blocksAbout.tool: "Use external tools to extend workflow capabilities" + nodes.ifElse.comparisonOperator.is not null: "is not null" + nodes.ifElse.comparisonOperator.is null: "is null" + singleRun.testRunLoop: "Test Run Loop" + tabs.-: "Default" 📄 Detailed report written to: i18n-analysis-report.json ✅ All namespace files and keys from main branch exist in current branch. 
@hyoban hyoban marked this pull request as ready for review December 29, 2025 05:51
@hyoban hyoban changed the title refactor: use JSON with flattened key for translation refactor(i18n): use JSON with flattened key and namespace Dec 29, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2025
@hyoban
Copy link
Member Author

hyoban commented Dec 29, 2025

If anyone has a merge conflict with this PR, ping me

@hyoban hyoban merged commit 6d0e364 into langgenius:main Dec 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

3 participants