fix(web): add null check for SSE stream bufferObj to prevent TypeError

[majiayu000]

Summary

• Added null/type validation for bufferObj after JSON.parse in handleStream function
• Prevents TypeError when server returns null or non-object data in SSE stream
• Added comprehensive test coverage for the fix

Test plan

• Added unit tests for null bufferObj handling
• Added unit tests for non-object bufferObj handling
• Added unit tests for valid message event handling
• Added unit tests for error status 400 handling
• Added unit tests for malformed JSON handling
• All new tests pass locally

fixes #29166

[gemini-code-assist]

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the stability of the Server-Sent Events (SSE) stream handling by introducing robust validation for incoming data. It specifically addresses potential TypeErrors that could arise if the server sends null or non-object data, ensuring the application gracefully handles unexpected or malformed responses.

Highlights

• Null/Type Check for SSE Stream Data: Added validation for bufferObj after JSON.parse in the handleStream function to ensure it's a valid object, preventing TypeError.
• Error Prevention: Prevents TypeError when the server sends null or non-object data in the Server-Sent Events (SSE) stream, improving robustness.
• Comprehensive Test Coverage: New unit tests have been added to cover various invalid and valid SSE stream data scenarios, including null/non-object bufferObj, malformed JSON, and error status 400.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a potential TypeError in the SSE stream handling by adding validation for null or non-object data returned from the server. The fix is straightforward and the inclusion of comprehensive unit tests is a great addition to ensure the robustness of the handleStream function. I have a few suggestions to improve the consistency of the error handling and the reliability of the new tests.