fix: fix create app xss issue

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30303

fix create app xss issue

Screenshots

Before	After
...	...

before

after

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial security enhancement by fixing a Cross-Site Scripting (XSS) vulnerability in the application creation and modification processes. It introduces server-side input validation to sanitize app names and descriptions, effectively preventing malicious scripts from being injected into the system. This change significantly strengthens the application's defense against a common class of web attacks, ensuring a more secure user experience.

Highlights

• XSS Prevention Implementation: Introduced a new _validate_xss_safe function in api/controllers/console/app/app.py to detect and prevent common Cross-Site Scripting (XSS) patterns in string inputs.
• Input Validation for App Payloads: Applied the XSS validation to the name and description fields of CreateAppPayload, UpdateAppPayload, and CopyAppPayload classes using Pydantic's @field_validator.
• Comprehensive Unit Tests: Added a new unit test file api/tests/unit_tests/controllers/console/app/test_xss_prevention.py with extensive tests covering various XSS attack vectors for app names and descriptions, ensuring the robustness of the new validation logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a potential XSS vulnerability by adding server-side validation for app names and descriptions. The changes introduce a regex-based denylist to block common XSS payloads like <script> tags and javascript: URIs. This validation is correctly applied during app creation, updates, and copying. The addition of a dedicated test file with comprehensive unit tests is excellent and ensures the fix is working as expected. My review includes a few suggestions to refine the implementation for better clarity and maintainability.

[Copilot]

Pull request overview

This PR addresses a critical XSS (Cross-Site Scripting) vulnerability in the app creation functionality by implementing server-side validation to reject potentially dangerous content in app names and descriptions.

Key Changes:

• Implements XSS prevention validation using regex patterns to detect and block malicious HTML, JavaScript, and other dangerous content
• Adds comprehensive field validators to CreateAppPayload, UpdateAppPayload, and CopyAppPayload models
• Provides extensive unit test coverage for XSS prevention across various attack vectors

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.

File	Description
api/controllers/console/app/app.py	Adds XSS validation patterns and _validate_xss_safe() function; applies validation to name and description fields in all app payload models
api/tests/unit_tests/controllers/console/app/test_xss_prevention.py	Comprehensive unit tests validating XSS prevention for script tags, iframes, event handlers, JavaScript protocols, SVG attacks, and other XSS vectors

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.