Conversation
Summary of ChangesHello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the internationalization (i18n) system by upgrading core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the i18n translation issue with the Trans component by updating i18next and react-i18next dependencies. The refactoring to separate the namespace from the i18nKey and use the ns prop is a clean solution that improves code clarity and type safety. The changes are applied consistently across all relevant files. Overall, this is a solid fix that aligns the codebase with the latest library practices.
There was a problem hiding this comment.
Pull request overview
This PR updates i18next dependencies to address type issues with the Trans component and adds missing namespace (ns) props to Trans component usages across the application. The dependency updates are substantial version jumps (i18next from v23 to v25, react-i18next from v15 to v16) to fix fallback typing issues where Trans was being typed as any.
Key changes:
- Updated i18next from ^23.16.8 to ^25.7.3 (major version upgrade)
- Updated react-i18next from ^15.7.4 to ^16.5.0 (major version upgrade)
- Added explicit
ns(namespace) props to Trans components where they were missing to maintain proper type safety and translation resolution
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/package.json | Updated i18next and react-i18next package versions |
| web/pnpm-lock.yaml | Updated lockfile with new dependency versions and peer dependency resolutions |
| web/app/components/workflow/block-selector/rag-tool-recommendations/index.tsx | Added ns="pipeline" to Trans component and fixed i18nKey format |
| web/app/components/rag-pipeline/components/rag-pipeline-header/publisher/popup.tsx | Added ns="datasetPipeline" to Trans component and fixed i18nKey format |
| web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx | Added ns="plugin" to Trans component |
| web/app/components/plugins/install-plugin/install-from-local-package/steps/install.tsx | Added ns="plugin" to Trans component |
| web/app/components/plugins/base/deprecation-notice.tsx | Added ns="plugin" to Trans component |
| web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.tsx | Added ns="common" to Trans components and fixed i18nKey formats |
| web/app/components/app/overview/settings/index.tsx | Added ns="appOverview" to Trans component |
| web/app/components/app/log/empty-element.tsx | Added ns="appLog" to Trans component and fixed i18nKey format |
| web/app/account/(commonLayout)/account-page/email-change-modal.tsx | Added ns="common" to Trans components and fixed i18nKey formats |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
Because the dependency is not up-to-date, the type of
Transis fallbacked toany.Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods