Skip to content

fix: missing i18n translation for Trans#30353

Merged
hyoban merged 1 commit intomainfrom
12-30-missing-migration-for-Trans
Dec 30, 2025
Merged

fix: missing i18n translation for Trans#30353
hyoban merged 1 commit intomainfrom
12-30-missing-migration-for-Trans

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Dec 30, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Because the dependency is not up-to-date, the type of Trans is fallbacked to any.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Copilot AI review requested due to automatic review settings December 30, 2025 02:43
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the internationalization (i18n) system by upgrading core i18next and react-i18next dependencies. The primary goal is to resolve type inference issues with the Trans component, which previously fell back to any due to outdated libraries. Concurrently, the changes standardize how translation keys are referenced by explicitly assigning namespaces to Trans components and refining the i18nKey paths, leading to more robust and maintainable translations across the application.

Highlights

  • Dependency Updates: The i18next library has been updated from version 23.16.8 to 25.7.3, and react-i18next has been updated from 15.7.4 to 16.5.0. These updates address issues where the Trans component's type was incorrectly inferred.
  • Explicit Namespace Declaration: The Trans component across various UI files now explicitly includes the ns (namespace) prop. This ensures that translation keys are correctly resolved within their designated namespaces.
  • i18nKey Refactoring: Several i18nKey values have been adjusted to remove redundant namespace prefixes, aligning them with the new explicit ns prop usage and streamlining translation key management.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the i18n translation issue with the Trans component by updating i18next and react-i18next dependencies. The refactoring to separate the namespace from the i18nKey and use the ns prop is a clean solution that improves code clarity and type safety. The changes are applied consistently across all relevant files. Overall, this is a solid fix that aligns the codebase with the latest library practices.

@hyoban hyoban merged commit 3505516 into main Dec 30, 2025
20 checks passed
@hyoban hyoban deleted the 12-30-missing-migration-for-Trans branch December 30, 2025 02:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates i18next dependencies to address type issues with the Trans component and adds missing namespace (ns) props to Trans component usages across the application. The dependency updates are substantial version jumps (i18next from v23 to v25, react-i18next from v15 to v16) to fix fallback typing issues where Trans was being typed as any.

Key changes:

  • Updated i18next from ^23.16.8 to ^25.7.3 (major version upgrade)
  • Updated react-i18next from ^15.7.4 to ^16.5.0 (major version upgrade)
  • Added explicit ns (namespace) props to Trans components where they were missing to maintain proper type safety and translation resolution

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/package.json Updated i18next and react-i18next package versions
web/pnpm-lock.yaml Updated lockfile with new dependency versions and peer dependency resolutions
web/app/components/workflow/block-selector/rag-tool-recommendations/index.tsx Added ns="pipeline" to Trans component and fixed i18nKey format
web/app/components/rag-pipeline/components/rag-pipeline-header/publisher/popup.tsx Added ns="datasetPipeline" to Trans component and fixed i18nKey format
web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx Added ns="plugin" to Trans component
web/app/components/plugins/install-plugin/install-from-local-package/steps/install.tsx Added ns="plugin" to Trans component
web/app/components/plugins/base/deprecation-notice.tsx Added ns="plugin" to Trans component
web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.tsx Added ns="common" to Trans components and fixed i18nKey formats
web/app/components/app/overview/settings/index.tsx Added ns="appOverview" to Trans component
web/app/components/app/log/empty-element.tsx Added ns="appLog" to Trans component and fixed i18nKey format
web/app/account/(commonLayout)/account-page/email-change-modal.tsx Added ns="common" to Trans components and fixed i18nKey formats
Files not reviewed (1)
  • web/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

3 participants