Skip to content

fix: fix provider_id is empty#30374

Merged
fatelei merged 1 commit intolanggenius:mainfrom
fatelei:issue-30372
Dec 30, 2025
Merged

fix: fix provider_id is empty#30374
fatelei merged 1 commit intolanggenius:mainfrom
fatelei:issue-30372

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 30, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30372

fix provider_id is empty

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the provider_id for workflow tools was not being properly set, leading to empty IDs. The fix involves updating the WorkflowToolProviderController to correctly retrieve and assign the provider_id from the database object, resolving issue #30372 and ensuring that workflow tool providers are accurately identified.

Highlights

  • Bug Fix: Empty Provider ID: Resolved an issue where the provider_id for workflow tools was incorrectly initialized as an empty string instead of being populated from the database object.
  • Data Accuracy: Ensured that the provider_id is now correctly assigned using db_provider.id, improving the accuracy and integrity of workflow tool provider data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where the provider_id for a WorkflowToolProviderController was being initialized as an empty string. The change correctly assigns the db_provider.id to this field, ensuring the controller is instantiated with the proper provider identifier. This is a direct and effective fix for the issue. Additionally, a minor formatting change removes an unnecessary blank line.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025
@fatelei fatelei merged commit c1af6a7 into langgenius:main Dec 30, 2025
11 checks passed
@cmlibo
Copy link

cmlibo commented Dec 30, 2025

刚刚还在看这个问题,终于修复了。未修复前现状:不同环境发布的Workflow工具,ID改成一致后,工具无法识别。添加新工具后,也无法执行,provider_id 为空。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants