Skip to content

refactor: Replace direct process.env.NODE_ENV checks with IS_PROD and IS_DEV constants.#30383

Merged
hjlarry merged 6 commits intomainfrom
fix/env-config-min
Dec 31, 2025
Merged

refactor: Replace direct process.env.NODE_ENV checks with IS_PROD and IS_DEV constants.#30383
hjlarry merged 6 commits intomainfrom
fix/env-config-min

Conversation

@lyzno1
Copy link
Member

@lyzno1 lyzno1 commented Dec 30, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 30, 2025 09:08
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lyzno1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the codebase to centralize and standardize how environment checks are performed. Instead of directly accessing process.env.NODE_ENV, the application now utilizes IS_PROD and IS_DEV constants. This change aims to improve code readability, maintainability, and consistency when differentiating between development and production environments.

Highlights

  • Standardized Environment Checks: Replaced direct process.env.NODE_ENV checks with dedicated IS_PROD and IS_DEV constants imported from the @/config module across various files.
  • Improved Readability and Maintainability: The use of explicit IS_PROD and IS_DEV constants makes environment-specific logic clearer and more consistent throughout the codebase.
  • Refactoring Across Components: Updates were applied to utility functions, error boundaries, analytics components, and service hooks to align with the new environment constant usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good refactoring that replaces direct process.env.NODE_ENV checks with the IS_PROD and IS_DEV constants, improving code readability and consistency. The changes are well-implemented across multiple files. I've noticed one place where the refactoring slightly changes the original behavior. I've added comments with suggestions to align it with the original intent while still using the new constants. Overall, great work!

lyzno1 and others added 4 commits December 30, 2025 17:11
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors environment checks by replacing direct process.env.NODE_ENV checks with centralized IS_PROD and IS_DEV constants from the config module. This improves code maintainability by providing a single source of truth for environment detection.

  • Imports IS_DEV and IS_PROD constants from @/config module
  • Replaces inline process.env.NODE_ENV comparisons with constant checks
  • Maintains cleaner and more consistent environment detection across the codebase

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
web/service/use-common.ts Replaces development check with IS_DEV constant in user profile metadata logic
web/app/components/header/github-star/index.tsx Uses !IS_DEV to conditionally enable GitHub star count fetching
web/app/components/base/zendesk/index.tsx Replaces production check with IS_PROD for nonce header retrieval
web/app/components/base/ga/index.tsx Replaces production check with IS_PROD for nonce header retrieval
web/app/components/base/error-boundary/index.tsx Uses IS_DEV for conditional error logging in error boundary
web/app/components/base/date-and-time-picker/utils/dayjs.ts Replaces non-production check with IS_DEV for parse failure warnings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hjlarry
hjlarry previously approved these changes Dec 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025
@hjlarry hjlarry merged commit 6958980 into main Dec 31, 2025
14 checks passed
@hjlarry hjlarry deleted the fix/env-config-min branch December 31, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

4 participants