Conversation
Summary of ChangesHello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's ESLint configuration by integrating a new set of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request attempts to add ESLint rules for the React Compiler. However, the current implementation is incorrect as it uses a deprecated stub package (eslint-plugin-react-hooks) and lists non-existent rules. My review points out this critical issue and provides detailed instructions on how to properly configure the official eslint-plugin-react-compiler to achieve the PR's goal.
There was a problem hiding this comment.
Pull request overview
This PR adds React Compiler lint rules to the ESLint configuration, enabling gradual adoption through warning-level enforcement. The React Compiler (integrated into eslint-plugin-react-hooks v7.0.1) helps optimize React applications by enforcing compiler-compatible patterns.
Key Changes:
- Adds 15 React Compiler lint rules to the ESLint configuration
- All rules set to 'warn' level for gradual adoption
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
fixes #30408
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods