Skip to content

chore: lint for react compiler#30417

Merged
hyoban merged 1 commit intomainfrom
12-31-lint-for-react-compiler
Dec 31, 2025
Merged

chore: lint for react compiler#30417
hyoban merged 1 commit intomainfrom
12-31-lint-for-react-compiler

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fixes #30408

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@hyoban hyoban requested a review from iamjoel as a code owner December 31, 2025 05:31
Copilot AI review requested due to automatic review settings December 31, 2025 05:31
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's ESLint configuration by integrating a new set of react-hooks rules. These rules are specifically aimed at preparing the codebase for the future adoption of the React Compiler, ensuring that potential compatibility issues or optimization opportunities are identified early. By setting these rules to 'warn', the change allows for a phased approach to refactoring and optimization without immediately breaking existing builds.

Highlights

  • ESLint Configuration Update: New ESLint rules have been added to web/eslint.config.mjs to support the React Compiler.
  • React Compiler Readiness: A comprehensive set of react-hooks rules, specifically designed for the React Compiler, have been introduced and configured as warnings to facilitate gradual adoption.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to add ESLint rules for the React Compiler. However, the current implementation is incorrect as it uses a deprecated stub package (eslint-plugin-react-hooks) and lists non-existent rules. My review points out this critical issue and provides detailed instructions on how to properly configure the official eslint-plugin-react-compiler to achieve the PR's goal.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds React Compiler lint rules to the ESLint configuration, enabling gradual adoption through warning-level enforcement. The React Compiler (integrated into eslint-plugin-react-hooks v7.0.1) helps optimize React applications by enforcing compiler-compatible patterns.

Key Changes:

  • Adds 15 React Compiler lint rules to the ESLint configuration
  • All rules set to 'warn' level for gradual adoption

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@hyoban hyoban merged commit 27be89c into main Dec 31, 2025
20 checks passed
@hyoban hyoban deleted the 12-31-lint-for-react-compiler branch December 31, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

3 participants