Skip to content

fix: fix when vision is disabled delete the configs#30420

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:vision_param
Dec 31, 2025
Merged

fix: fix when vision is disabled delete the configs#30420
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:vision_param

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30394

fix when vision is disabled delete the configs

Screenshots

Before After
... ...

before

Screen.Recording.2025-12-31.at.14.13.25.mov

after

Screen.Recording.2025-12-31.at.14.12.27.mov

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where vision configurations were not correctly cleared when the vision feature was turned off. By introducing a mechanism to explicitly delete these configurations upon disabling vision, the change ensures that the application maintains a clean state and avoids potential conflicts or unexpected behavior stemming from lingering settings.

Highlights

  • Configuration Management: Implemented logic to automatically delete vision-related configurations when the vision feature is disabled, ensuring data consistency and preventing stale settings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug where vision configurations were not being deleted when the feature was disabled. The added logic ensures that the configs property is removed from the payload when vision is turned off. I have included one suggestion to improve the clarity and maintainability of the conditional logic.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@crazywoola crazywoola merged commit ae43ad5 into langgenius:main Dec 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants