fix: fix when vision is disabled delete the configs#30420
fix: fix when vision is disabled delete the configs#30420crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where vision configurations were not correctly cleared when the vision feature was turned off. By introducing a mechanism to explicitly delete these configurations upon disabling vision, the change ensures that the application maintains a clean state and avoids potential conflicts or unexpected behavior stemming from lingering settings. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where vision configurations were not being deleted when the feature was disabled. The added logic ensures that the configs property is removed from the payload when vision is turned off. I have included one suggestion to improve the clarity and maintainability of the conditional logic.
Important
Fixes #<issue number>.Summary
fix #30394
fix when vision is disabled delete the configs
Screenshots
before
Screen.Recording.2025-12-31.at.14.13.25.mov
after
Screen.Recording.2025-12-31.at.14.12.27.mov
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods