feat: add AgentMaxIterationError exc#30423
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new exception, AgentMaxIterationError, to improve the robustness of agent execution. It prevents agents from entering infinite loops by explicitly raising an error when they exceed their configured maximum iteration limit while still attempting to invoke tools. This ensures more predictable behavior and clearer error reporting for agent-based workflows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new AgentMaxIterationError exception to handle scenarios where an agent exceeds its configured maximum number of iterations. The exception is raised in both CotAgentRunner and FunctionCallAgentRunner when they detect that the agent is attempting to continue processing beyond the iteration limit instead of providing a final answer. The implementation is clean and effectively addresses the problem. I have one minor suggestion to improve code readability by simplifying a conditional check.
Important
Fixes #<issue number>.Summary
fix #30419
add AgentMaxIterationError exc
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods