Skip to content

feat: add AgentMaxIterationError exc#30423

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30419
Dec 31, 2025
Merged

feat: add AgentMaxIterationError exc#30423
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30419

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30419

add AgentMaxIterationError exc

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🤖 feat:agent Agent related topics labels Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new exception, AgentMaxIterationError, to improve the robustness of agent execution. It prevents agents from entering infinite loops by explicitly raising an error when they exceed their configured maximum iteration limit while still attempting to invoke tools. This ensures more predictable behavior and clearer error reporting for agent-based workflows.

Highlights

  • New Exception for Agent Iteration Limits: Introduced AgentMaxIterationError to specifically handle scenarios where an agent exceeds its maximum allowed iterations.
  • Enhanced Agent Loop Detection: Implemented checks in both cot_agent_runner.py and fc_agent_runner.py to raise AgentMaxIterationError when an agent reaches its iteration limit and attempts further tool calls instead of concluding.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new AgentMaxIterationError exception to handle scenarios where an agent exceeds its configured maximum number of iterations. The exception is raised in both CotAgentRunner and FunctionCallAgentRunner when they detect that the agent is attempting to continue processing beyond the iteration limit instead of providing a final answer. The implementation is clean and effectively addresses the problem. I have one minor suggestion to improve code readability by simplifying a conditional check.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@crazywoola crazywoola merged commit 9b6b2f3 into langgenius:main Dec 31, 2025
11 checks passed
@dosubot dosubot bot mentioned this pull request Feb 27, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 feat:agent Agent related topics lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

2 participants