build: bring back babel-loader, add build check#30427
Conversation
Summary of ChangesHello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reintroduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR reintroduces babel-loader (v10.0.0) as a dependency and adds a build check step to the GitHub Actions CI workflow to catch build failures earlier in the development process.
Key Changes:
- Added babel-loader v10.0.0 package dependency
- Configured knip to ignore the babel-loader dependency (likely used by Storybook's webpack configuration)
- Added a new "Web build check" step in the GitHub Actions style workflow to run
pnpm run buildon web changes
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/package.json | Adds babel-loader ^10.0.0 to dependencies |
| web/pnpm-lock.yaml | Updates lockfile to include babel-loader 10.0.0 and its dependency resolutions |
| web/knip.config.ts | Adds babel-loader to ignoreDependencies list to prevent knip from flagging it as unused |
| .github/workflows/style.yml | Adds build check step to CI workflow that runs after other web checks |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request re-introduces babel-loader as a dependency and configures Knip to ignore it. The changes are straightforward. My main feedback is to move babel-loader from dependencies to devDependencies, as it's a build-time tool and not needed in a production runtime environment. This is a best practice for managing dependencies and helps optimize the production build size. The PR title also mentions adding a 'build check', but I don't see any related file changes for that.
I am having trouble creating individual review comments. Click here to see my feedback.
web/package.json (76)
babel-loader is a build-time dependency, so it should be in devDependencies rather than dependencies. This prevents it from being included in production builds where it's not needed, helping to keep the final bundle size smaller. Please move it to the devDependencies section.
Important
Fixes #<issue number>.Summary
fix ci https://github.com/langgenius/dify/actions/runs/20614549934/job/59204774527
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods