Skip to content

build: bring back babel-loader, add build check#30427

Merged
hyoban merged 3 commits intomainfrom
12-31-build
Dec 31, 2025
Merged

build: bring back babel-loader, add build check#30427
hyoban merged 3 commits intomainfrom
12-31-build

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix ci https://github.com/langgenius/dify/actions/runs/20614549934/job/59204774527

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Copilot AI review requested due to automatic review settings December 31, 2025 08:29
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reintroduces babel-loader into the web project's dependencies, upgrading it to version 10.0.0. This change is accompanied by an update to the pnpm-lock.yaml file to manage the new dependency and a configuration adjustment in knip.config.ts to ensure babel-loader is correctly ignored by the dependency analyzer. The reintroduction of babel-loader likely addresses specific build requirements or compatibility issues, aiming to stabilize or improve the build process.

Highlights

  • Reintroduction of babel-loader: The babel-loader package, specifically version 10.0.0, has been added back into the web project's direct dependencies in package.json.
  • Dependency Lock File Update: The pnpm-lock.yaml file has been updated to reflect the inclusion of babel-loader@10.0.0 and its associated resolved dependencies, ensuring consistent builds.
  • Knip Configuration Adjustment: babel-loader has been added to the ignoreDependencies list within web/knip.config.ts to prevent the dependency analyzer from flagging it as an unused dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/style.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reintroduces babel-loader (v10.0.0) as a dependency and adds a build check step to the GitHub Actions CI workflow to catch build failures earlier in the development process.

Key Changes:

  • Added babel-loader v10.0.0 package dependency
  • Configured knip to ignore the babel-loader dependency (likely used by Storybook's webpack configuration)
  • Added a new "Web build check" step in the GitHub Actions style workflow to run pnpm run build on web changes

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
web/package.json Adds babel-loader ^10.0.0 to dependencies
web/pnpm-lock.yaml Updates lockfile to include babel-loader 10.0.0 and its dependency resolutions
web/knip.config.ts Adds babel-loader to ignoreDependencies list to prevent knip from flagging it as unused
.github/workflows/style.yml Adds build check step to CI workflow that runs after other web checks
Files not reviewed (1)
  • web/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@hyoban hyoban merged commit 184077c into main Dec 31, 2025
14 checks passed
@hyoban hyoban deleted the 12-31-build branch December 31, 2025 08:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-introduces babel-loader as a dependency and configures Knip to ignore it. The changes are straightforward. My main feedback is to move babel-loader from dependencies to devDependencies, as it's a build-time tool and not needed in a production runtime environment. This is a best practice for managing dependencies and helps optimize the production build size. The PR title also mentions adding a 'build check', but I don't see any related file changes for that.

I am having trouble creating individual review comments. Click here to see my feedback.

web/package.json (76)

medium

babel-loader is a build-time dependency, so it should be in devDependencies rather than dependencies. This prevents it from being included in production builds where it's not needed, helping to keep the final bundle size smaller. Please move it to the devDependencies section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

3 participants