Skip to content

chore: add jotai store#30432

Merged
lyzno1 merged 3 commits intomainfrom
12-31-jotai-provider
Dec 31, 2025
Merged

chore: add jotai store#30432
lyzno1 merged 3 commits intomainfrom
12-31-jotai-provider

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Copilot AI review requested due to automatic review settings December 31, 2025 09:23
@hyoban hyoban requested a review from iamjoel as a code owner December 31, 2025 09:23
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Jotai, a state management library, into the application's core structure by wrapping the main layout with JotaiProvider. This foundational change establishes the necessary environment for leveraging Jotai's atom-based state management, paving the way for more efficient and streamlined global state handling in future development.

Highlights

  • Jotai Integration: The JotaiProvider has been added to the root layout, enabling Jotai for global state management across the application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Jotai for state management by adding its provider to the root layout. While the implementation is straightforward, it raises an architectural concern as the project already uses Zustand. My review includes a suggestion to re-evaluate the need for a second state management library to avoid increasing bundle size and complexity. I've also included a minor suggestion to improve import ordering for better code consistency.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the Jotai Provider to the application's root layout, enabling centralized state management using Jotai atoms throughout the application. This is necessary to support existing Jotai usage (e.g., in web/context/i18n.ts) and future atom-based state management.

  • Wraps the component tree with JotaiProvider at the root level
  • Adds the process import from 'node:process'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
Signed-off-by: yyh <yuanyouhuilyz@gmail.com>
@lyzno1 lyzno1 merged commit ee1d0df into main Dec 31, 2025
14 checks passed
@lyzno1 lyzno1 deleted the 12-31-jotai-provider branch December 31, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

3 participants