fix(web): stop thinking timer when user clicks stop button

[majiayu000]

Summary

• Fix the issue where the thinking timer continues to run after user clicks stop button
• The timer now properly stops when isResponding is explicitly set to false

Changes

• Modified the condition to check for isResponding === false instead of !isResponding
• This distinguishes between explicit stop (false) and undefined context (when component is used outside ChatContextProvider)
• Added comprehensive tests for the ThinkBlock component

Test plan

• New unit tests for ThinkBlock component pass
• Type check passes (pnpm type-check:tsgo)
• Lint check passes (pnpm lint:fix)

fixes #20679

[gemini-code-assist]

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical UI bug where the 'thinking' timer in the application would not correctly stop when a user manually interrupted a response. By refining the conditional logic that governs the timer's cessation, the system now accurately reflects the user's intent to stop the process, ensuring a more responsive and intuitive user experience. The update also includes new, thorough unit tests for the ThinkBlock component to validate the fix and enhance overall code robustness.

Highlights

• Bug Fix: Resolved an issue where the 'thinking' timer would continue to run even after a user clicked the stop button, leading to an inaccurate UI state.
• Logic Refinement: The condition for stopping the thinking timer was updated from !isResponding to isResponding === false. This change explicitly differentiates between a user-initiated stop and scenarios where isResponding might be undefined (e.g., when the component is used outside its intended context).
• Improved Test Coverage: Comprehensive unit tests have been added for the ThinkBlock component, specifically covering rendering, timer behavior, ENDTHINKFLAG handling, and various edge cases, ensuring the new logic works as expected and preventing future regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where the thinking timer would not stop when the user clicks the stop button. The change from !isResponding to isResponding === false is the right approach to distinguish between an explicit stop action and the component being used outside of its context provider. The newly added tests in think-block.spec.tsx are comprehensive and cover the fix, edge cases, and different rendering states. I've added one suggestion to refactor a test case to reduce code duplication and improve maintainability. Overall, this is a solid contribution.