Skip to content

chore: update dockerignore#30460

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
hsiong:fix/30459
Jan 5, 2026
Merged

chore: update dockerignore#30460
crazywoola merged 1 commit intolanggenius:mainfrom
hsiong:fix/30459

Conversation

@hsiong
Copy link
Contributor

@hsiong hsiong commented Jan 2, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #30459

This PR improves Docker build cache stability for the web frontend by updating .dockerignore to exclude Git metadata and other build-irrelevant files.

Previously, the .git directory was included in the Docker build context for web/Dockerfile. Since files under .git/ change frequently during normal Git operations and CI checkouts, the COPY . . instruction invalidated Docker layer cache on every build, causing the builder stage (pnpm build:docker) to run repeatedly even when no web source code had changed.

By explicitly excluding .git and related files, Docker layer caching now behaves as expected, significantly reducing unnecessary rebuilds in both local development and CI pipelines.

This change only affects build configuration and does not modify application logic or runtime behavior.

Screenshots

Before After
Web Docker image rebuilds on every run due to cache invalidation Docker layer cache is reused; pnpm build:docker runs only when relevant files change

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@hsiong hsiong requested a review from iamjoel as a code owner January 2, 2026 08:01
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hsiong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #30459 by resolving a Docker build inefficiency for the web frontend. Previously, the inclusion of the .git directory and other temporary build artifacts in the Docker build context led to frequent cache invalidation, forcing the pnpm build:docker stage to re-run unnecessarily. By expanding the .dockerignore file to exclude these volatile and irrelevant files, Docker's layer caching mechanism can now operate effectively, resulting in faster and more stable builds across development and CI environments.

Highlights

  • Docker Build Cache Stability: Improved Docker build cache stability for the web frontend by preventing unnecessary rebuilds.
  • .dockerignore Update: Updated web/.dockerignore to explicitly exclude Git metadata (.git, .gitignore) and other build-irrelevant files (dist, build, coverage, .pnpm-store).
  • Performance Improvement: Significantly reduces unnecessary Docker image rebuilds in both local development and CI pipelines by allowing Docker layer caching to function as expected.
  • No Application Logic Change: This change solely affects build configuration and does not modify application logic or runtime behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hsiong hsiong changed the title fix: #30459 chore: #30459 Jan 2, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and addresses a Docker cache invalidation issue by adding several patterns to .dockerignore, most notably .git. The changes are sound and will improve build times. I've added a few suggestions to make the path matching more specific by anchoring them to the root of the build context. This is a best practice that improves the robustness of the ignore file and prevents accidentally excluding files in subdirectories.

@fatelei fatelei changed the title chore: #30459 chore: update dockerignore Jan 2, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola crazywoola merged commit 4bb08b9 into langgenius:main Jan 5, 2026
12 checks passed
@hsiong hsiong deleted the fix/30459 branch January 5, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants