Skip to content

fix: INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH settings#30463

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
hsiong:fix/30461
Jan 5, 2026
Merged

fix: INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH settings#30463
crazywoola merged 1 commit intolanggenius:mainfrom
hsiong:fix/30461

Conversation

@hsiong
Copy link
Contributor

@hsiong hsiong commented Jan 2, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fix #30461

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@hsiong hsiong requested a review from iamjoel as a code owner January 2, 2026 08:55
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hsiong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #30461 by enhancing the configuration management for the maximum number of tokens used in segmentation, particularly for Docker deployments. It introduces a dedicated environment variable to ensure that this critical setting can be correctly applied and managed within containerized environments, improving consistency and flexibility.

Highlights

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH environment variable to the .env.example file, which allows for runtime configuration in Docker environments. While this is a good practice for containerized applications, the current implementation introduces a duplicate configuration value alongside NEXT_PUBLIC_INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH. This can create confusion and potential maintenance issues. My review includes a suggestion to improve the comment to clarify the purpose of this new variable and its relationship with the existing one, which will enhance the clarity and maintainability of the configuration.

@fatelei fatelei changed the title fix: #30461 fix: INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH settings Jan 2, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola
Copy link
Member

BTW, you should add this to the docker/.env.example as well.

@crazywoola crazywoola self-assigned this Jan 5, 2026
@crazywoola crazywoola merged commit 693daea into langgenius:main Jan 5, 2026
11 checks passed
@hsiong
Copy link
Contributor Author

hsiong commented Jan 5, 2026

BTW, you should add this to the docker/.env.example as well.

Good point, I should add this to docker/.env.example as well.
Should I include it in this PR or open a separate PR?

@hsiong hsiong deleted the fix/30461 branch January 10, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants