chore: Standardized the OpenAI icon#30471
Conversation
Summary of ChangesHello @hjlarry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the visual representation of OpenAI models within the application by removing multiple color-specific OpenAI icons and their corresponding rendering logic. The change consolidates the display to a single, consistent OpenAI icon, simplifying icon management and ensuring a uniform user experience across different OpenAI model versions. This addresses issue #30470. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to standardize the OpenAI icon by removing several color variations (Blue, Teal, Violet) and using a single OpenaiYellow icon. The changes involve deleting the corresponding icon JSON and TSX files, and updating the icon index and usage sites. While the cleanup is good, the logic for displaying the standardized icon seems incomplete. The current condition only applies the yellow icon to OpenAI models with names starting with 'o', leaving other models like gpt-4 to use a generic icon. I've suggested a fix to apply the standardized icon to all OpenAI models to fully achieve the goal of this PR.
web/app/components/header/account-setting/model-provider-page/model-icon/index.tsx Show resolved Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR standardizes OpenAI model icons by removing colored variants and simplifying the icon selection logic. Previously, different GPT model families (gpt-4, gpt-4o, gpt-4.1) used different colored OpenAI icons. Now, only models starting with 'o' (like o1, o3-mini) use the OpenaiYellow icon, while other OpenAI models fall back to the standard provider icon.
Key changes:
- Removed model-specific icon logic for GPT-4 variants in favor of a single condition for "o" series models
- Deleted three unused icon components (OpenaiBlue, OpenaiTeal, OpenaiViolet) and their associated files
- Updated icon exports to remove references to deleted components
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/app/components/header/account-setting/model-provider-page/model-icon/index.tsx | Simplified icon selection logic by removing conditional checks for gpt-4.1, gpt-4o, and gpt-4 models; retained only the condition for models starting with 'o' |
| web/app/components/base/icons/src/public/llm/index.ts | Removed exports for OpenaiBlue, OpenaiTeal, and OpenaiViolet icon components |
| web/app/components/base/icons/src/public/llm/OpenaiViolet.tsx | Deleted violet variant of OpenAI icon component |
| web/app/components/base/icons/src/public/llm/OpenaiViolet.json | Deleted violet variant icon data file |
| web/app/components/base/icons/src/public/llm/OpenaiTeal.tsx | Deleted teal variant of OpenAI icon component |
| web/app/components/base/icons/src/public/llm/OpenaiTeal.json | Deleted teal variant icon data file |
| web/app/components/base/icons/src/public/llm/OpenaiBlue.tsx | Deleted blue variant of OpenAI icon component |
| web/app/components/base/icons/src/public/llm/OpenaiBlue.json | Deleted blue variant icon data file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
fix #30470
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods