feat: add flask command file-usage#30500
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the database management toolkit by adding a new Flask command, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new file-usage command that allows users to query and display where files are referenced across various database tables, supporting filtering by file ID, storage key, and source table/column patterns, along with pagination and JSON output. The command reuses existing logic for identifying file references. Review comments highlight two main areas for improvement: the current pagination implementation collects all file usages into memory before applying limits, which could lead to high memory consumption for large datasets and should be refactored to use a generator for better memory efficiency; additionally, the src filter's wildcard matching performs inefficient database queries for each table, and it's suggested to perform this filtering in-memory using Python's fnmatch module to reduce database round-trips.
Important
Fixes #<issue number>.Summary
fix #30477
add flask command file-usage
Screenshots
after
Screen.Recording.2026-01-04.at.16.10.04.mov
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods