fix(plugins): enhance search to match name, label and description#30501
fix(plugins): enhance search to match name, label and description#30501
Conversation
Previously plugin search only matched plugin_id, making it difficult to find plugins by their display name or description. Now searches across plugin_id, name, declaration name, localized label and localized description for better discoverability.
Summary of ChangesHello @zhsama, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to significantly enhance the user experience for discovering plugins by broadening the scope of the search functionality. Previously limited to just the plugin ID, the search now intelligently considers various descriptive attributes, including names, labels, and descriptions, with full support for internationalization. This change directly addresses discoverability issues, allowing users to find relevant plugins more intuitively and efficiently. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the plugin search functionality to include matching against the plugin's name, label, and description, which is a great improvement for discoverability. The implementation introduces a matchesSearchQuery helper function to contain the search logic. My review includes a suggestion to refactor this function for better readability, robustness, and maintainability.
Important
Fixes #<issue number>.Summary
Improve plugin search functionality to support matching by plugin name, label, and description for better discoverability.
Screenshots
|


|
|
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods