Conversation
This reverts commit 84cbf05.
Summary of ChangesHello @CodingOnStar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive revert of a previously introduced feature concerning model total credits. The rollback primarily impacts the frontend, leading to the removal of various LLM provider icons, simplification of the quota display mechanism, and updates to user-facing text to reflect a more focused set of supported models for message credits. Additionally, some minor refactoring of icon rendering types and application context definitions is included. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts the "feat: model total credits" feature. The changes mostly involve removing code related to trial credits and a global quota panel, which seems correct given the goal of the PR. I've also noticed some unrelated fixes and refactoring. My review includes a couple of suggestions for improvement: one regarding an incorrect TypeScript type for a ref prop in several icon components, and another questioning a change in dimensions for an icon that might be unintentional. Overall, the revert appears to be on the right track.
There was a problem hiding this comment.
Pull request overview
This PR reverts the "model total credits" feature (PR #26942), removing credit tracking functionality from the workspace context and UI components.
Key changes:
- Removed workspace credit fields (trial_credits, trial_credits_used, next_credit_reset_date)
- Reverted quota panel component from unified credits display back to per-provider quotas
- Removed provider-specific icon files and enums for Gemini, xAI, DeepSeek, and Tongyi
- Simplified i18n strings to reference only OpenAI instead of multiple providers
Reviewed changes
Copilot reviewed 40 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/models/common.ts | Removed credit-related fields from ICurrentWorkspace type |
| web/context/app-context.tsx | Removed isValidatingCurrentWorkspace and credit initialization |
| web/i18n/**/common.json | Reverted model provider strings and removed credit reset date string |
| web/i18n/**/billing.json | Simplified message credit tooltip to reference only OpenAI |
| web/app/components/header/account-setting/model-provider-page/utils.ts | Removed ModelProviderQuotaGetPaid enum and modelNameMap |
| web/app/components/header/account-setting/model-provider-page/provider-added-card/quota-panel.tsx | Reverted from unified credit display to per-provider quota panel |
| web/app/components/header/account-setting/model-provider-page/provider-added-card/index.tsx | Renamed showModelProvider to showQuota and restored QuotaPanel import |
| web/app/components/header/account-setting/model-provider-page/provider-added-card/credential-panel.tsx | Removed IS_CLOUD_EDITION conditional checks |
| web/app/components/header/account-setting/model-provider-page/index.tsx | Removed QuotaPanel component and mutateCurrentWorkspace effect |
| web/app/components/plugins/provider-card.tsx | Added empty parentheses to onSuccess callback |
| web/app/components/billing/apps-full-in-dialog/index.spec.tsx | Removed credit fields from test mock data |
| web/app/components/base/icons/src/public/llm/* | Removed icon files for Gemini, xAI, DeepSeek, Tongyi, and OpenAI variants |
| web/app/components/base/icons/src/public/tracing/* | Fixed ref type and JSON attribute ordering in icon files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reverts #26942