Skip to content

refactor(code_node): implement DI for the code node#30519

Merged
laipz8200 merged 9 commits intomainfrom
f08d-node-di-code
Jan 4, 2026
Merged

refactor(code_node): implement DI for the code node#30519
laipz8200 merged 9 commits intomainfrom
f08d-node-di-code

Conversation

@laipz8200
Copy link
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #30506

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Dependency Injection into the CodeNode implementation, enhancing its modularity and testability. It extracts configuration-related limits into a dedicated CodeNodeLimits dataclass and updates the node factory to manage and inject these dependencies, leading to a more flexible and maintainable codebase for workflow code execution.

Highlights

  • Dependency Injection for CodeNode: The CodeNode class has been refactored to use Dependency Injection (DI) for its CodeExecutor, CodeNodeProvider, and CodeNodeLimits. This makes the node more modular and testable by allowing these dependencies to be passed in during initialization rather than being hardcoded or globally accessed.
  • Introduction of CodeNodeLimits: A new CodeNodeLimits dataclass has been introduced to centralize and manage various execution limits for code nodes, such as maximum string length, number range, precision, and array lengths. This replaces direct references to dify_config values within the CodeNode logic.
  • DifyNodeFactory Integration: The DifyNodeFactory has been updated to support the new DI pattern for CodeNode. It now accepts optional code_executor, code_providers, and code_limits arguments during its initialization and passes them to the CodeNode constructor when creating a code node instance.
  • Updated Test Infrastructure: All relevant integration and unit tests have been updated to accommodate the new DI pattern, ensuring that CodeNode instances are correctly initialized with the necessary injected dependencies, including the new CodeNodeLimits.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CodeNode to use Dependency Injection for its dependencies like CodeExecutor, CodeNodeProvider, and execution limits. This is a great improvement for making the node more configurable and testable. The introduction of the CodeNodeLimits dataclass is also a good practice for grouping related configurations. My review includes a couple of suggestions to further improve the design and maintainability.

@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 11:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 4, 2026
Copy link
Contributor

@hjlarry hjlarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2026
@laipz8200 laipz8200 merged commit 06ba40f into main Jan 4, 2026
15 checks passed
@laipz8200 laipz8200 deleted the f08d-node-di-code branch January 4, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

2 participants