fix: when first setup after auto login error#30523
Conversation
Summary of ChangesHello @sszaodian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug that caused auto-login failures during the initial application setup. Previously, the password was not being correctly encoded before being sent to the login endpoint, leading to authentication errors. The fix ensures that the password is now properly encrypted using a dedicated utility function, thereby resolving the login issue and providing a seamless first-time user experience immediately after setup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where the automatic login after the initial setup was failing. The fix correctly applies Base64 encoding to the password before sending it to the /login endpoint, which aligns with the server's expectation. The change is correct and addresses the issue. I've added a couple of suggestions to improve code clarity by renaming the imported encryptPassword function to better reflect its behavior (encoding vs. encryption), which is a good practice for maintainability.
Summary
when first setup auto login error
the password should base64
before

after

Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods