Skip to content

fix: when first setup after auto login error#30523

Merged
hjlarry merged 3 commits intolanggenius:mainfrom
sszaodian:fix/first_setup_after_auto_login_error
Jan 4, 2026
Merged

fix: when first setup after auto login error#30523
hjlarry merged 3 commits intolanggenius:mainfrom
sszaodian:fix/first_setup_after_auto_login_error

Conversation

@sszaodian
Copy link
Contributor

Summary

when first setup auto login error
the password should base64

before
image

after
image

image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sszaodian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that caused auto-login failures during the initial application setup. Previously, the password was not being correctly encoded before being sent to the login endpoint, leading to authentication errors. The fix ensures that the password is now properly encrypted using a dedicated utility function, thereby resolving the login issue and providing a seamless first-time user experience immediately after setup.

Highlights

  • Bug Fix: Auto-Login Error on First Setup: Resolved an issue where users encountered an auto-login error immediately after completing the initial setup process, preventing them from accessing the application.
  • Password Encryption for Setup: Implemented password encryption (specifically, base64 encoding as per the description) for the password field during the initial setup phase to ensure it's correctly handled by the login API.
  • Integration of Encryption Utility: The encryptPassword utility function from @/utils/encryption is now utilized in the installForm.tsx component to process the password before submission.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug where the automatic login after the initial setup was failing. The fix correctly applies Base64 encoding to the password before sending it to the /login endpoint, which aligns with the server's expectation. The change is correct and addresses the issue. I've added a couple of suggestions to improve code clarity by renaming the imported encryptPassword function to better reflect its behavior (encoding vs. encryption), which is a good practice for maintainability.

@hjlarry hjlarry changed the title fix when first setup after auto login error fix: when first setup after auto login error Jan 4, 2026
Copy link
Contributor

@hjlarry hjlarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2026
@hjlarry hjlarry merged commit 2b83807 into langgenius:main Jan 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants