chore: Add a new rule for import lint#30526
Conversation
Summary of ChangesHello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new import linter rule to enforce architectural boundaries within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new import linting rule to prevent core.workflow modules from depending on infrastructure layers like ext_database and ext_redis. This is a positive architectural improvement. The existing violations are correctly identified and added to an ignore list. My review includes a suggestion to add a comment to the ignore list to better track this technical debt.
…xtensions.ext_database`/`extensions.ext_redis` imports, include `extensions` in root packages, and allow indirect imports while baselining current direct usages so lint stays green. **Summary** - chore(import-linter): add workflow db/redis forbidden rule with direct-import baseline - test(lint): run make lint - test(types): run make type-check **Tests** - `make lint` - `make type-check`
4c6dd4b to 8142e1c Compare
Important
Fixes #<issue number>.Summary
part of #30506
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods