Skip to content

chore: Add a new rule for import lint#30526

Merged
crazywoola merged 2 commits intomainfrom
a908-add-a-new-rule-f
Jan 5, 2026
Merged

chore: Add a new rule for import lint#30526
crazywoola merged 2 commits intomainfrom
a908-add-a-new-rule-f

Conversation

@laipz8200
Copy link
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #30506

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new import linter rule to enforce architectural boundaries within the api directory. The primary goal is to prevent unintended dependencies from the core.workflow module to infrastructure-related extensions like ext_database and ext_redis, thereby maintaining a cleaner and more modular codebase. It also explicitly allows a set of pre-existing, justified imports to avoid breaking current functionality.

Highlights

  • Import Linter Configuration Update: The .importlinter configuration file has been updated to include the extensions package as a root package and enable the inclusion of external packages in the linting process.
  • New Workflow Infrastructure Dependency Rule: A new import linter contract, workflow-infrastructure-dependencies, has been introduced. This rule forbids direct imports from core.workflow to extensions.ext_database and extensions.ext_redis, with specific exceptions for existing, necessary dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new import linting rule to prevent core.workflow modules from depending on infrastructure layers like ext_database and ext_redis. This is a positive architectural improvement. The existing violations are correctly identified and added to an ignore list. My review includes a suggestion to add a comment to the ignore list to better track this technical debt.

@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 11:54
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 4, 2026
@laipz8200 laipz8200 requested a review from crazywoola January 4, 2026 13:51
…xtensions.ext_database`/`extensions.ext_redis` imports, include `extensions` in root packages, and allow indirect imports while baselining current direct usages so lint stays green. **Summary** - chore(import-linter): add workflow db/redis forbidden rule with direct-import baseline - test(lint): run make lint - test(types): run make type-check **Tests** - `make lint` - `make type-check`
@laipz8200 laipz8200 force-pushed the a908-add-a-new-rule-f branch from 4c6dd4b to 8142e1c Compare January 4, 2026 16:40
@laipz8200 laipz8200 removed the request for review from QuantumGhost January 4, 2026 17:04
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola crazywoola merged commit eb321ad into main Jan 5, 2026
15 checks passed
@crazywoola crazywoola deleted the a908-add-a-new-rule-f branch January 5, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

2 participants