refactor: use contains_any instead of Chaining where = where | f#30559
refactor: use contains_any instead of Chaining where = where | f#30559crazywoola merged 2 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes how document ID filters are applied within Weaviate queries for both vector and full-text searches. By transitioning from a recursive Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great refactoring. Using contains_any instead of chaining OR filters with | is much more efficient, readable, and idiomatic for the Weaviate client. It correctly addresses the potential performance and recursion depth issues with a large number of document IDs. I've added a couple of minor suggestions to further improve maintainability by using a constant for a repeated string literal.
Important
Fixes #<issue number>.Summary
fix #29750
use contains_any instead of Chaining where = where | f
Screenshots
Before (problematic - deep nesting):
ors = [Filter.by_property("document_id").equal(x) for x in doc_ids]
where = ors[0]
for f in ors[1:]:
where = where | f # Creates (A | (B | (C | ...))) nesting
After (efficient - flat structure):
where = Filter.by_property("document_id").contains_any(doc_ids)
Benefits:
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods