Skip to content

refactor: use contains_any instead of Chaining where = where | f#30559

Merged
crazywoola merged 2 commits intolanggenius:mainfrom
fatelei:issue-29750
Jan 5, 2026
Merged

refactor: use contains_any instead of Chaining where = where | f#30559
crazywoola merged 2 commits intolanggenius:mainfrom
fatelei:issue-29750

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 5, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #29750

use contains_any instead of Chaining where = where | f

Screenshots

Before After
... ...
Method Line Change
search_by_vector 361 Uses contains_any(doc_ids)
search_by_full_text 408 Uses contains_any(doc_ids)

Before (problematic - deep nesting):
ors = [Filter.by_property("document_id").equal(x) for x in doc_ids]
where = ors[0]
for f in ors[1:]:
where = where | f # Creates (A | (B | (C | ...))) nesting

After (efficient - flat structure):
where = Filter.by_property("document_id").contains_any(doc_ids)

Benefits:

  • Avoids deep nesting issues with 100+ document IDs
  • Better performance (single operation vs. recursive tree evaluation)
  • Cleaner, more idiomatic Weaviate code

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@fatelei fatelei requested a review from JohnJyong as a code owner January 5, 2026 06:32
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes how document ID filters are applied within Weaviate queries for both vector and full-text searches. By transitioning from a recursive OR chaining mechanism to the more direct contains_any method, the change addresses potential performance bottlenecks and deep nesting issues that could arise with numerous document IDs. The primary impact is a more efficient, readable, and robust filtering process within the Weaviate integration.

Highlights

  • Refactor Weaviate Filtering Logic: Replaced a chained where = where | f pattern with Filter.by_property("document_id").contains_any(doc_ids) for improved efficiency and readability in Weaviate queries.
  • Performance Improvement: The new approach avoids deep nesting issues that could occur with a large number of document IDs (100+), leading to better performance and a flatter, more efficient query structure.
  • Code Cleanliness: The refactoring results in cleaner and more idiomatic Weaviate code, simplifying the logic for applying document ID filters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. label Jan 5, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great refactoring. Using contains_any instead of chaining OR filters with | is much more efficient, readable, and idiomatic for the Weaviate client. It correctly addresses the potential performance and recursion depth issues with a large number of document IDs. I've added a couple of minor suggestions to further improve maintainability by using a constant for a repeated string literal.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola crazywoola merged commit 631f999 into langgenius:main Jan 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

3 participants