Skip to content

feat(graph-engine): add command to update variables at runtime#30563

Merged
laipz8200 merged 5 commits intomainfrom
651d-a-new-command-to
Jan 5, 2026
Merged

feat(graph-engine): add command to update variables at runtime#30563
laipz8200 merged 5 commits intomainfrom
651d-a-new-command-to

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 5, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Adds a new GraphEngine command to update variables at runtime, wiring it through the Redis command channel, manager API, and command handler. Includes unit tests covering command serialization and variable pool updates. Fixes #30562.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Add a new command for GraphEngine to update a group of variables. This command takes a group of variable selectors and new values. When the engine receives the command, it will update the corresponding variable in the variable pool. If it does not exist, it will add it; if it does, it will overwrite it. Both behaviors should be treated the same and do not need to be distinguished.
…n and remove value type validation - test(graph-engine): update UpdateVariablesCommand tests to pass concrete Variable instances - fix(graph-engine): align VariableUpdate values with selector before adding to VariablePool Tests not run.
… pool updates from Variable.selector, updating tests accordingly
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to dynamically update variables within a running workflow. By adding a new UpdateVariablesCommand and its corresponding handler, the system can now receive and process requests to modify workflow variables on the fly. This enhancement provides greater flexibility and control over workflow execution, allowing for real-time adjustments to workflow state without requiring a restart. The changes span across command definition, command channel integration, command processing logic, and a public interface for sending these commands, all backed by new unit tests.

Highlights

  • New Command Type: Introduced a new UpdateVariablesCommand to allow dynamic modification of variables within a running workflow. This command includes a list of VariableUpdate objects, each specifying a new value for a variable identified by its selector.
  • Command Handler Implementation: A dedicated UpdateVariablesCommandHandler has been implemented. This handler processes the UpdateVariablesCommand by iterating through the provided updates and adding or modifying variables in the workflow's VariablePool.
  • Redis Channel Integration: The RedisChannel now recognizes and correctly deserializes the new UpdateVariablesCommand when fetching commands from Redis, ensuring that these commands can be transmitted and processed by the graph engine.
  • Graph Engine Command Processing: The GraphEngine has been updated to register the UpdateVariablesCommandHandler with its CommandProcessor. This ensures that when an UpdateVariablesCommand is received, it is routed to the appropriate handler for execution.
  • Manager Interface for Sending Commands: A new static method, send_update_variables_command, has been added to the GraphEngineManager. This provides a simplified interface for external components to send UpdateVariablesCommands to a specific workflow via the Redis channel.
  • Comprehensive Unit Tests: New unit tests have been added to validate the functionality of the UpdateVariablesCommand, covering its deserialization from Redis and its correct processing by the GraphEngine to update the variable pool.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title a new command to update the variables (vibe-kanban) feat(graph-engine): add command to update variables at runtime Jan 5, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new update_variables command to the workflow engine, allowing for dynamic variable updates during execution. The implementation is well-structured, touching upon command definition, Redis channel handling, command processing, and engine integration. The changes are accompanied by comprehensive unit and integration tests, ensuring the new functionality is robust. I have one suggestion to simplify the code in the new command handler.

…lers.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@laipz8200 laipz8200 marked this pull request as ready for review January 5, 2026 07:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Jan 5, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@laipz8200 laipz8200 merged commit a9e2c05 into main Jan 5, 2026
15 checks passed
@laipz8200 laipz8200 deleted the 651d-a-new-command-to branch January 5, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

2 participants