Skip to content

chore: fix lint in i18n#30571

Merged
lyzno1 merged 1 commit intomainfrom
1-5-fix-lint
Jan 5, 2026
Merged

chore: fix lint in i18n#30571
lyzno1 merged 1 commit intomainfrom
1-5-fix-lint

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Jan 5, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

c29cfd1#diff-60f7807d4d9576fb28e0ce0d3790bfbe8b09dbe16e5f7f4576e59126f836d73a

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@hyoban hyoban requested a review from iamjoel as a code owner January 5, 2026 08:00
Copilot AI review requested due to automatic review settings January 5, 2026 08:00
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hyoban, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a chore task to fix linting issues within the internationalization (i18n) files. It systematically removes specific translation keys that are no longer in use, thereby streamlining the translation resources and enhancing overall code hygiene.

Highlights

  • Internationalization Cleanup: Removed several unused or redundant translation keys related to model providers from common.json files across multiple languages.
  • Code Maintainability: Improved the maintainability of i18n files by eliminating obsolete entries, ensuring that only necessary translations are present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused translation keys from internationalization (i18n) files to fix lint issues. The cleanup removes four obsolete translation keys that are no longer referenced in the codebase, ensuring consistency across all language files.

  • Removes 4 unused translation keys related to model provider card states and reset dates
  • Updates 18 language locale files to maintain i18n consistency
  • All removed keys have no references in the codebase, confirming they are safe to delete

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/i18n/zh-Hant/common.json Removed 4 unused modelProvider translation keys
web/i18n/vi-VN/common.json Removed 4 unused modelProvider translation keys
web/i18n/uk-UA/common.json Removed 4 unused modelProvider translation keys
web/i18n/tr-TR/common.json Removed 4 unused modelProvider translation keys
web/i18n/th-TH/common.json Removed 4 unused modelProvider translation keys
web/i18n/sl-SI/common.json Removed 4 unused modelProvider translation keys
web/i18n/ru-RU/common.json Removed 4 unused modelProvider translation keys
web/i18n/ro-RO/common.json Removed 4 unused modelProvider translation keys
web/i18n/pt-BR/common.json Removed 4 unused modelProvider translation keys
web/i18n/pl-PL/common.json Removed 4 unused modelProvider translation keys
web/i18n/ko-KR/common.json Removed 4 unused modelProvider translation keys
web/i18n/it-IT/common.json Removed 4 unused modelProvider translation keys
web/i18n/id-ID/common.json Removed 4 unused modelProvider translation keys
web/i18n/hi-IN/common.json Removed 4 unused modelProvider translation keys
web/i18n/fr-FR/common.json Removed 4 unused modelProvider translation keys
web/i18n/fa-IR/common.json Removed 4 unused modelProvider translation keys
web/i18n/es-ES/common.json Removed 4 unused modelProvider translation keys
web/i18n/de-DE/common.json Removed 4 unused modelProvider translation keys
web/i18n/ar-TN/common.json Removed 4 unused modelProvider translation keys

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a cleanup of unused internationalization (i18n) keys across multiple language files. The changes remove modelProvider.card.modelAPI, modelProvider.card.modelNotSupported, modelProvider.card.modelSupported, and modelProvider.resetDate keys. This is a good maintenance task that improves code clarity by removing obsolete translation strings. The changes are consistent and correct. The pull request is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

3 participants