refactor: split changes for api/controllers/console/datasets/hit_test…

[asukaminato0721]

…ing_base.py

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #29289

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @asukaminato0721, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the argument parsing and validation mechanism within the hit_testing_base.py file. By migrating from flask_restx.reqparse to Pydantic models, the change aims to enhance data integrity, improve code readability, and streamline the handling of incoming request parameters for hit testing operations. This is part of a broader refactoring effort to improve the codebase.

Highlights

• Argument Parsing Refactor: The argument parsing logic for hit testing has been refactored to utilize Pydantic models for validation and data extraction, replacing the previous flask_restx.reqparse implementation.
• Code Modernization: The parse_args method in HitTestingBase has been updated to accept a payload and leverage HitTestingPayload.model_validate for robust input validation and model_dump for structured output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the argument parsing in hit_testing_base.py from flask_restx.reqparse to Pydantic models. This is a good improvement for validation and type safety. However, I've found a critical regression where the query field is now incorrectly marked as required, which would break requests that only provide attachment_ids. Please see my detailed comment.

[Copilot]

Pull request overview

This PR refactors the hit testing base controller by replacing flask_restx.reqparse with Pydantic model validation for request payload parsing. This is part of a larger effort (#29289) to modernize the codebase and improve type safety.

Key changes:

• Removed the reqparse import from flask_restx
• Replaced the parse_args() implementation to use HitTestingPayload Pydantic model validation
• Updated method signature to accept an optional payload parameter and added return type annotation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.