Skip to content

refactor: split changes for api/controllers/web/conversation.py#30582

Merged
crazywoola merged 3 commits intolanggenius:mainfrom
asukaminato0721:split-api-controllers-web-conversation.py
Jan 6, 2026
Merged

refactor: split changes for api/controllers/web/conversation.py#30582
crazywoola merged 3 commits intolanggenius:mainfrom
asukaminato0721:split-api-controllers-web-conversation.py

Conversation

@asukaminato0721
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #29289

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @asukaminato0721, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the api/controllers/web/conversation.py file. The primary goal is to modernize and standardize API input validation by migrating from the reqparse utility to Pydantic models. This change improves the clarity, maintainability, and robustness of the API endpoints responsible for managing user conversations, ensuring that incoming data adheres strictly to defined schemas.

Highlights

  • Pydantic Model Integration: Replaced flask_restful.reqparse with Pydantic models for request argument and body validation, enhancing API input validation and schema definition.
  • New Schema Definitions: Introduced ConversationListQuery for validating parameters when fetching conversation lists and ConversationRenamePayload for validating the payload when renaming conversations.
  • Centralized Schema Registration: Utilized register_schema_models to register the new Pydantic schemas, streamlining documentation and validation within the API namespace.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the request parameter and payload parsing in api/controllers/web/conversation.py by replacing reqparse.RequestParser with Pydantic models. It introduces ConversationListQuery for validating query parameters in the conversation list API and ConversationRenamePayload for validating the payload when renaming a conversation, including specific validation rules for fields like last_id and name. These new Pydantic models are then used to parse and validate incoming request data, and they are registered with web_ns.

@asukaminato0721 asukaminato0721 marked this pull request as ready for review January 5, 2026 15:30
Copilot AI review requested due to automatic review settings January 5, 2026 15:30
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the conversation controller in the web API by replacing flask-restx's reqparse with Pydantic models for request validation. This is part of a broader effort (issue #29289) to modernize the codebase's validation approach.

Key Changes:

  • Introduced two Pydantic models (ConversationListQuery and ConversationRenamePayload) to replace reqparse argument parsers
  • Migrated validation logic from reqparse to Pydantic field validators and model validators
  • Updated request parsing to use request.args.to_dict() and web_ns.payload directly with Pydantic validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@crazywoola crazywoola merged commit c0331b2 into langgenius:main Jan 6, 2026
17 checks passed
@asukaminato0721 asukaminato0721 deleted the split-api-controllers-web-conversation.py branch January 6, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

3 participants