refactor: generate_url to support scenario to build url

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30589 #25168

for plugin for_external is false, use internal file url
for render use file url

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the file URL generation mechanism to provide more granular control over whether an internal or external URL is constructed. By introducing a for_external flag, the system can now differentiate between scenarios requiring external public access and those, like plugin interactions, that should utilize internal network paths, thereby improving efficiency and security for file handling within the application. This change addresses issue #30589.

Highlights

• URL Generation Refinement: Introduced a 'for_external' parameter to key URL generation functions (get_signed_file_url and sign_tool_file) to explicitly control whether an internal or external base URL is constructed for file access.
• Plugin URL Handling: Ensured that the File.to_plugin_parameter method now explicitly generates URLs using the internal file URL (by setting for_external=False), addressing a specific scenario for plugins to use appropriate network paths.
• Centralized URL Logic: Consolidated the logic for determining the base URL (between dify_config.FILES_URL and dify_config.INTERNAL_FILES_URL) within the helper functions, improving maintainability and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors URL generation for files to support different URLs for internal and external access. A new for_external parameter has been added to get_signed_file_url and sign_tool_file to control which base URL is used. This is then used in File.generate_url and leveraged in File.to_plugin_parameter to generate internal URLs for plugins. The changes are logical and the accompanying test has been updated correctly. I've left one comment regarding code duplication that could be addressed to improve maintainability.

[QuantumGhost]

LGTM

This requires a upgrade / migration guide in release note.