fix: _model_to_insertion_dict missing id

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30602

The function was omitting the id field when preparing data for bulk insertion. Since workflow_draft_variables.id is a primary key with NOT NULL constraint and no database-level default, the raw SQL bulk insert (pg_insert/mysql_insert) was failing.

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug that prevented successful bulk insertion of WorkflowDraftVariable records into the database. The _model_to_insertion_dict utility function, responsible for converting model objects into dictionaries for insertion, was inadvertently omitting the id field. This oversight caused database-level NOT NULL constraint violations for the id column, leading to failed bulk operations. The fix ensures the id is correctly included, restoring the integrity and functionality of bulk data insertions.

Highlights

• Fix _model_to_insertion_dict: The _model_to_insertion_dict function was missing the id field when preparing data for bulk insertion, which caused failures due to a NOT NULL constraint on workflow_draft_variables.id.
• Database Bulk Insertion: This omission led to raw SQL bulk insert operations (e.g., pg_insert/mysql_insert) failing because the primary key id was not provided, violating database constraints.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a bug where the id field was missing during the bulk insertion of WorkflowDraftVariable records. The change is simple, targeted, and effectively resolves the issue described, which could lead to NOT NULL constraint violations in the database. The fix is well-aligned with the ORM model's behavior of generating IDs on the client side. Good job on this fix.