Skip to content

fix(db): parameterize sessionmaker with Session#30612

Merged
crazywoola merged 1 commit intomainfrom
9823-improve-type-ann
Jan 6, 2026
Merged

fix(db): parameterize sessionmaker with Session#30612
crazywoola merged 1 commit intomainfrom
9823-improve-type-ann

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #30610.

Update the global session factory typing in api/core/db/session_factory.py to use sessionmaker[Session], preserving the inner Session type for consumers and improving type-checking accuracy without runtime changes. No dependencies required.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Updated `api/core/db/session_factory.py` to annotate `_session_maker` and `get_session_maker` as `sessionmaker[Session]`, keeping the inner Session type for consumers. Tests not run (not requested).
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the type safety and clarity within the session_factory.py module by refining the type annotations for sessionmaker. By explicitly specifying sessionmaker[Session], the changes ensure that static analysis tools can more accurately infer the type of database sessions being managed, thereby improving code maintainability and reducing the likelihood of type-related errors.

Highlights

  • Type Annotation Improvement: The type annotation for the _session_maker variable has been updated from sessionmaker to sessionmaker[Session] to explicitly define the generic type.
  • Function Return Type Update: The return type annotation for the get_session_maker function has been changed to sessionmaker[Session], providing more precise type information.
  • Static Method Return Type Update: The return type annotation for the SessionFactory.get_session_maker static method has also been updated to sessionmaker[Session] for consistency and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title Improve type annotation for sessionmaker in session_factory.py (vibe-kanban) fix(db): parameterize sessionmaker with Session Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly improves the type annotations for sessionmaker to include the inner Session type, which enhances type safety and code clarity. The changes are consistent across the module. I've also included a suggestion to refactor the session factory logic to avoid using a global variable, which would improve the code's maintainability and testability by encapsulating the state within the SessionFactory class.

@laipz8200 laipz8200 marked this pull request as ready for review January 6, 2026 06:55
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 6, 2026
@laipz8200 laipz8200 requested review from crazywoola and fatelei and removed request for QuantumGhost January 6, 2026 06:57
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@crazywoola crazywoola merged commit 1f5d744 into main Jan 6, 2026
15 of 16 checks passed
@crazywoola crazywoola deleted the 9823-improve-type-ann branch January 6, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

2 participants