Skip to content

feat: use more universal C.UTF-8 instead of en_US.UTF-8#30621

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30620
Jan 6, 2026
Merged

feat: use more universal C.UTF-8 instead of en_US.UTF-8#30621
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30620

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30620

C.UTF-8 is the standard choice for Docker/container environments, while en_US.UTF-8 is mainly used for desktop applications targeting users in specific countries.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Jan 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the locale settings within the Docker environment by transitioning from en_US.UTF-8 to C.UTF-8. This modification aims to enhance the robustness and portability of the application when deployed in containerized settings, ensuring consistent and universally compatible UTF-8 encoding behavior across diverse Docker hosts and distributions.

Highlights

  • Standardized Locale Settings: The LANG and LC_ALL environment variables have been updated from en_US.UTF-8 to C.UTF-8 across various Docker configuration files.
  • Enhanced Container Compatibility: This change improves the universality and compatibility of the application within containerized environments, as C.UTF-8 is the standard and recommended locale for Docker and similar setups, unlike en_US.UTF-8 which is more specific to desktop applications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default locale from en_US.UTF-8 to the more universal C.UTF-8 across various Docker configuration files. This is a good improvement for containerized environments to prevent potential encoding issues. The changes are consistent, but I've suggested also setting LC_ALL for the oceanbase service for better robustness and consistency with other parts of the configuration.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@crazywoola crazywoola merged commit 2cc89d3 into langgenius:main Jan 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

2 participants