feat: use more universal C.UTF-8 instead of en_US.UTF-8#30621
feat: use more universal C.UTF-8 instead of en_US.UTF-8#30621crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing the locale settings within the Docker environment by transitioning from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the default locale from en_US.UTF-8 to the more universal C.UTF-8 across various Docker configuration files. This is a good improvement for containerized environments to prevent potential encoding issues. The changes are consistent, but I've suggested also setting LC_ALL for the oceanbase service for better robustness and consistency with other parts of the configuration.
Important
Fixes #<issue number>.Summary
fix #30620
C.UTF-8 is the standard choice for Docker/container environments, while en_US.UTF-8 is mainly used for desktop applications targeting users in specific countries.
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods