fix(workflow): pass correct user_from/invoke_from into graph init#30637
fix(workflow): pass correct user_from/invoke_from into graph init#30637
Conversation
Threaded invoke_from/user_from from the generate entities into graph initialization and single-node execution for workflow, advanced chat, and pipeline runners, and aligned WorkflowEntry user_from to the web-app-only end-user rule. Tests not run (not requested).
…e explicit graph params Updated `WorkflowBasedAppRunner._resolve_user_from` to return account for explore/debugger and end-user otherwise, and made `_init_graph` require explicit `user_from`/`invoke_from` to avoid hidden defaults. Tests not run (not requested).
… and update user_from resolution Tests not run (not requested).
make lint (pass) make type-check (pass)
Summary of ChangesHello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of user_from and invoke_from parameters by centralizing the logic and passing them down from the runner, which is a great improvement. The changes are well-implemented across the different app runners. I've made a couple of suggestions to further improve code clarity and consistency by simplifying how these parameters are determined in a couple of files, following the cleaner pattern already present in pipeline/pipeline_runner.py.
…om in app runners
…user_from refactor
Important
Fixes #<issue number>.Summary
Fixes #30636.
Propagates
user_fromandinvoke_fromfrom app runners into workflow graph initialization for normal runs, aligns user-from resolution so web apps map to end-user while all other entry points map to account, and keeps single-node runs explicitly in debugger/account context.Tests:
make lint,make type-check.Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods