refactor(api): clarify published RAG pipeline invoke naming#30644
refactor(api): clarify published RAG pipeline invoke naming#30644asukaminato0721 merged 1 commit intomainfrom
Conversation
…published RAG pipeline runs Updated RAG pipeline controllers, generators, tasks, and tests to use the new enum name while keeping the value "published" for compatibility. Tests not run (not requested). If you want to verify, run: `uv run --project api --dev dev/pytest/pytest_unit_tests.sh`.
Summary of ChangesHello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a naming ambiguity by renaming the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the InvokeFrom.PUBLISHED enum member to InvokeFrom.PUBLISHED_PIPELINE for better clarity, updating its usage across multiple files. The changes are straightforward and improve code readability. I have one suggestion to improve consistency within the InvokeFrom enum itself.
Important
Fixes #<issue number>.Summary
Fixes #30643.
Clarify the published RAG pipeline invocation source by renaming
InvokeFrom.PUBLISHEDtoInvokeFrom.PUBLISHED_PIPELINEwhile keeping the serialized value as "published" for compatibility. Update pipeline controllers, generator/task logic, and related tests to use the new enum name.Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods