Skip to content

refactor(api): clarify published RAG pipeline invoke naming#30644

Merged
asukaminato0721 merged 1 commit intomainfrom
5bd8-choose-a-better
Jan 6, 2026
Merged

refactor(api): clarify published RAG pipeline invoke naming#30644
asukaminato0721 merged 1 commit intomainfrom
5bd8-choose-a-better

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #30643.

Clarify the published RAG pipeline invocation source by renaming InvokeFrom.PUBLISHED to InvokeFrom.PUBLISHED_PIPELINE while keeping the serialized value as "published" for compatibility. Update pipeline controllers, generator/task logic, and related tests to use the new enum name.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
…published RAG pipeline runs Updated RAG pipeline controllers, generators, tasks, and tests to use the new enum name while keeping the value "published" for compatibility. Tests not run (not requested). If you want to verify, run: `uv run --project api --dev dev/pytest/pytest_unit_tests.sh`.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a naming ambiguity by renaming the InvokeFrom.PUBLISHED enum member to InvokeFrom.PUBLISHED_PIPELINE. The original name was confusing and lacked specificity, making it difficult to understand its exact context. The new name explicitly indicates that the invocation is related to a published RAG pipeline workflow, thereby enhancing readability and reducing potential misunderstandings for developers.

Highlights

  • Enum Renaming: The InvokeFrom.PUBLISHED enum member has been renamed to InvokeFrom.PUBLISHED_PIPELINE to provide a more descriptive and less confusing name, explicitly indicating its use with RAG pipelines.
  • Codebase Consistency: All occurrences of the old InvokeFrom.PUBLISHED enum member have been updated across the codebase to use the new InvokeFrom.PUBLISHED_PIPELINE name, ensuring consistency and correctness.
  • Improved Documentation: A clarifying comment has been added to the InvokeFrom.PUBLISHED_PIPELINE enum definition, explaining that it indicates an invocation running a published RAG pipeline workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title Choose a better name for InvokeFrom.Published (vibe-kanban) refactor(api): clarify published RAG pipeline invoke naming Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the InvokeFrom.PUBLISHED enum member to InvokeFrom.PUBLISHED_PIPELINE for better clarity, updating its usage across multiple files. The changes are straightforward and improve code readability. I have one suggestion to improve consistency within the InvokeFrom enum itself.

@laipz8200 laipz8200 marked this pull request as ready for review January 6, 2026 11:13
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 6, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@asukaminato0721 asukaminato0721 merged commit 55de731 into main Jan 6, 2026
16 of 17 checks passed
@asukaminato0721 asukaminato0721 deleted the 5bd8-choose-a-better branch January 6, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

3 participants