Skip to content

fix: fix not record access token#30654

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30618
Jan 7, 2026
Merged

fix: fix not record access token#30654
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30618

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30618

fix not record access token

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@fatelei fatelei requested review from douxc and iamjoel as code owners January 6, 2026 14:51
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug where the access token was not being stored or recorded following a successful user login via email and password. By integrating the setWebAppAccessToken function into the authentication flow, the system now correctly captures and persists the access token, thereby ensuring that user sessions are properly maintained and authenticated after login.

Highlights

  • Access Token Recording: The pull request addresses an issue where the access token was not being recorded after a successful email and password login, ensuring proper session management and user authentication.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies mail-and-password-auth.tsx to import setWebAppAccessToken and then calls this function to store the access_token received upon a successful email and password login. There were no review comments provided.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026
@crazywoola crazywoola merged commit ace8ad4 into langgenius:main Jan 7, 2026
10 checks passed
@bing2008
Copy link

# Create response with cookies instead of returning tokens in body
response = make_response({"result": "success"})
set_access_token_to_cookie(request, response, token_pair.access_token)

The back end of API layer didn't return the value of access_token in response.data object,

so the front end web control will still run into error when using it :

setWebAppAccessToken(res.data.access_token)

but the try catch block stopped the error raise you won't see it.

catch (error) {
if ((error as ResponseError).code === 'authentication_failed') {
Toast.notify({
type: 'error',
message: t('error.invalidEmailOrPassword', { ns: 'login' }),
})
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants