fix: add DB_TYPE environment variable to unit tests

[fghpdf]

Summary

Add monkeypatch.setenv("DB_TYPE", "postgresql") to all test functions in test_dify_config.py that set DB_* environment variables.

Changes

• Added DB_TYPE to test_dify_config
• Added DB_TYPE to test_http_timeout_defaults
• Added DB_TYPE to test_flask_configs
• Added DB_TYPE to test_inner_api_config_exist
• Added DB_TYPE to test_db_extras_options_merging
• Added DB_TYPE to test_celery_broker_url_with_special_chars_password

Why

The DB_TYPE configuration variable was recently added to DatabaseConfig, but the unit tests were not updated to include this environment variable. This ensures tests properly set the required configuration.

Closes #30543

[gemini-code-assist]

Summary of Changes

Hello @fghpdf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates several unit test functions in test_dify_config.py to include the DB_TYPE environment variable. This ensures that tests correctly simulate the application's environment, preventing potential failures due to missing database type configuration, which was recently added to the DatabaseConfig.

Highlights

• Test Configuration Update: The DB_TYPE environment variable has been added to all relevant test functions within test_dify_config.py to ensure proper configuration during unit tests.
• Addressing Missing Configuration: This change rectifies an oversight where the DB_TYPE configuration, recently introduced to DatabaseConfig, was not reflected in the existing unit tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the DB_TYPE environment variable to several unit tests in test_dify_config.py. This change is necessary to align the tests with recent updates to the database configuration. While the changes are correct, they highlight existing code duplication in the test setup. I've added a comment suggesting a refactoring using a pytest fixture to centralize the environment variable setup, which would improve the overall maintainability of the test suite. This can be considered for a follow-up.

[Copilot]

Pull request overview

This PR adds the DB_TYPE environment variable to all test functions in test_dify_config.py that configure database-related environment variables. This ensures tests explicitly set the database type configuration after DB_TYPE was recently added to the DatabaseConfig class.

• Added monkeypatch.setenv("DB_TYPE", "postgresql") to 6 test functions
• Placement is consistent across all tests (before DB_USERNAME)
• Uses "postgresql" which matches the default value in DatabaseConfig

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.