Skip to content

refactor: port api/controllers/console/app/audio.py api/controllers/console/app/message.py api/controllers/console/auth/data_source_oauth.py api/controllers/console/auth/forgot_password.py api/controllers/console/workspace/endpoint.py#30680

Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom
asukaminato0721:28015
Feb 2, 2026

Conversation

@asukaminato0721
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #28015

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
@asukaminato0721 asukaminato0721 changed the title port api/controllers/console/app/workflow.py refactor: port api/controllers/console/app/workflow.py Jan 7, 2026
@gemini-code-assist

This comment was marked as outdated.

@asukaminato0721 asukaminato0721 marked this pull request as ready for review January 7, 2026 07:15
Copilot AI review requested due to automatic review settings January 7, 2026 07:15
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 7, 2026
gemini-code-assist[bot]

This comment was marked as outdated.

This comment was marked as outdated.

@asukaminato0721
Copy link
Contributor Author

/gemini review

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

This comment was marked as outdated.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 1, 2026
@asukaminato0721 asukaminato0721 changed the title refactor: port api/controllers/console/app/workflow.py refactor: port api/controllers/console/app/audio.py api/controllers/console/app/message.py api/controllers/console/auth/data_source_oauth.py api/controllers/console/auth/forgot_password.py api/controllers/console/workspace/endpoint.py Feb 2, 2026
@asukaminato0721
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several API controllers to use Pydantic models for schema definition, improving code clarity, type safety, and maintainability. The introduction of register_schema_models and its consistent application across files, along with simplifications in clickzetta_volume_storage.py, are well-executed improvements. However, a security issue was identified regarding the exposure of sensitive password reset tokens in API responses.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 2, 2026
@asukaminato0721 asukaminato0721 merged commit ac222a4 into langgenius:main Feb 2, 2026
19 checks passed
@asukaminato0721 asukaminato0721 deleted the 28015 branch February 2, 2026 09:03
@dosubot dosubot bot mentioned this pull request Feb 4, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

3 participants